Comments (3)
Could there perhaps be a wiki added to this repo with a gallery of common fixups
I have it on my long TODO list to build Reindeer with buck2 OSS. That should carry with it a healthy amount of fixups.
Another idea would be to link to other Meta project's fixups:
- https://github.com/facebook/buck2/tree/main/shim/third-party/rust/fixups
- https://github.com/facebook/ocamlrep/tree/main/shim/third-party/rust/fixups
Another interesting possibility is a command reindeer add that can apply known fixups...
I don't think that's something we want to take on and maintain. I'd be more interested in exploring cases where we can make fixups unnecessary altogether.
from reindeer.
I don't think an add
command is necessary, just a common set of fixups that are maintained and people can contribute to. Honestly, I just spent about 20 minutes combing through buck2's fixup directory, copying/pasting things from within it, and it would have been much nicer if I could have just copy-pasted a big common directory that was maybe over-approximate, but tested to work.
Is there any reason a bunch of fixups couldn't just be put under fixups/
at the root of this repo, people can contribute, and we just say it's best effort? Literally just "Copy fixups/
next to reindeer.toml
, run reindeer buckify
, and it might work if you're lucky. Patches welcome to add or fix things" is enough. It shouldn't even be that hard to use buck2 binaries to test the crate builds in a CI step too, but just something that's shared and re-usable would be great.
from reindeer.
Whatever makes it easier to find all the fixups people are using successfully would make adoption much easier. It is annoying to even suggest it, but in a lot of ways until an alternative to Cargo achieves some broader mindshare we're looking at a WineDB situation I think.
As it stands you have to really want an alternative to Cargo and power through. :D
I'd be more interested in exploring cases where we can make fixups unnecessary altogether.
That is of course the best option. Its going to come down to a lot of crates intentionally avoiding certain bad habits from Cargo I guess.
from reindeer.
Related Issues (15)
- To simplify installation, this should be crated HOT 1
- some confusion with the latest reindeer HOT 5
- Failed to coerce attr `licenses` when using `vendor=false` on a crate containing license metadata HOT 3
- Crates in lockfile are incompatible with current nightly Rust
- Unresolved dependencies with specs crate HOT 6
- safe_arch crate doesn't build in vendored mode (fails to copy all required sources) when precise_srcs=true. HOT 1
- bracket-terminal crate ends up depending on two version of winit and can't be compiled HOT 1
- How do you correctly handle fixups for multiple crate versions? HOT 1
- workspace support
- Warning and duplicates
- Workspace support has broken the example and it's unclear how to proceed HOT 4
- SSL linking problems when building HOT 2
- [Documentation] Please document how patches.crates-io works
- crates.io download URLs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reindeer.