Test fail STAGE 15 -- TEST QUERY PLAN about cg-sql HOT 8 CLOSED

/*
CREATE PROC foo ()
BEGIN
  CREATE TABLE t4(
    id LONG_INT PRIMARY KEY AUTOINCREMENT,
    data BLOB
  );
END;
*/

CQL_WARN_UNUSED cql_code foo(sqlite3 *_Nonnull _db_) {
  cql_code _rc_ = SQLITE_OK;
  _rc_ = cql_exec(_db_,
    "CREATE TABLE t4( "
      "id INTEGER PRIMARY KEY AUTOINCREMENT, "  // <----- LOOK AT THAT <<---- <-----
      "data BLOB "
    ")");
  if (_rc_ != SQLITE_OK) goto cql_cleanup;
  _rc_ = SQLITE_OK;

cql_cleanup:
  return _rc_;
}

sources % cat x.sql

  CREATE TABLE t4(
    id LONG_INT PRIMARY KEY AUTOINCREMENT,
    data BLOB
  );

sources % out/cql --in x.sql --rt schema_upgrade --cg upgrader.sql --global_proc upgrader
% cat upgrader.sql
-- @generated SignedSource<<deadbeef8badf00ddefec8edfacefeed>>

-- no columns will be considered hidden in this script
-- DDL in procs will not count as declarations
@SCHEMA_UPGRADE_SCRIPT;

-- schema crc -5635641207918476938

-- declare sqlite_master -- 
CREATE TABLE sqlite_master (
  type TEXT NOT NULL,
  name TEXT NOT NULL,
  tbl_name TEXT NOT NULL,
  rootpage INTEGER NOT NULL,
  sql TEXT NOT NULL
);

-- declare full schema of tables and views to be upgraded and their dependencies -- 
CREATE TABLE t4(
  id LONG_INT PRIMARY KEY AUTOINCREMENT,
  data BLOB
);

-- facets table declaration --
CREATE TABLE IF NOT EXISTS upgrader_cql_schema_facets(
  facet TEXT NOT NULL PRIMARY KEY,
  version LONG INTEGER NOT NULL
);

-- saved facets table declaration --
CREATE TEMP TABLE upgrader_cql_schema_facets_saved(
  facet TEXT NOT NULL PRIMARY KEY,
  version LONG INTEGER NOT NULL
);

-- helper proc for testing for the presence of a column/type
CREATE PROCEDURE upgrader_check_column_exists(table_name TEXT NOT NULL, decl TEXT NOT NULL, OUT present BOOL NOT NULL)
BEGIN
  SET present := (SELECT EXISTS(SELECT * FROM sqlite_master WHERE tbl_name = table_name AND sql GLOB decl));
END;

-- helper proc for creating the schema version table
CREATE PROCEDURE upgrader_create_cql_schema_facets_if_needed()
BEGIN
  CREATE TABLE IF NOT EXISTS upgrader_cql_schema_facets(
    facet TEXT NOT NULL PRIMARY KEY,
    version LONG INTEGER NOT NULL
  );
END;

-- helper proc for saving the schema version table
CREATE PROCEDURE upgrader_save_cql_schema_facets()
BEGIN
  DROP TABLE IF EXISTS upgrader_cql_schema_facets_saved;
  CREATE TEMP TABLE upgrader_cql_schema_facets_saved(
    facet TEXT NOT NULL PRIMARY KEY,
    version LONG INTEGER NOT NULL
  );
  INSERT INTO upgrader_cql_schema_facets_saved
    SELECT * FROM upgrader_cql_schema_facets;
END;

-- helper proc for setting the schema version of a facet
CREATE PROCEDURE upgrader_cql_set_facet_version(_facet TEXT NOT NULL, _version LONG INTEGER NOT NULL)
BEGIN
  INSERT OR REPLACE INTO upgrader_cql_schema_facets (facet, version) VALUES(_facet, _version);
END;

-- helper proc for getting the schema version of a facet
CREATE PROCEDURE upgrader_cql_get_facet_version(_facet TEXT NOT NULL, out _version LONG INTEGER NOT NULL)
BEGIN
  BEGIN TRY
    SET _version := (SELECT version FROM upgrader_cql_schema_facets WHERE facet = _facet LIMIT 1);
  END TRY;
  BEGIN CATCH
    SET _version := -1;
  END CATCH;
END;

-- helper proc for getting the schema version CRC for a version index
CREATE PROCEDURE upgrader_cql_get_version_crc(_v INTEGER NOT NULL, out _crc LONG INTEGER NOT NULL)
BEGIN
  BEGIN TRY
    SET _crc := (SELECT version FROM upgrader_cql_schema_facets WHERE facet = 'cql_schema_v'||_v LIMIT 1);
  END TRY;
  BEGIN CATCH
    SET _crc := -1;
  END CATCH;
END;

-- helper proc for setting the schema version CRC for a version index
CREATE PROCEDURE upgrader_cql_set_version_crc(_v INTEGER NOT NULL, _crc LONG INTEGER NOT NULL)
BEGIN
  INSERT OR REPLACE INTO upgrader_cql_schema_facets (facet, version) VALUES('cql_schema_v'||_v, _crc);
END;

-- helper proc to reset any triggers that are on the old plan --
DECLARE PROCEDURE cql_exec_internal(sql TEXT NOT NULL) USING TRANSACTION;
CREATE PROCEDURE upgrader_cql_drop_legacy_triggers()
BEGIN
  DECLARE C CURSOR FOR SELECT name from sqlite_master
     WHERE type = 'trigger' AND name GLOB 'tr__*';
  LOOP FETCH C
  BEGIN
    call cql_exec_internal(printf('DROP TRIGGER %s;', C.name));
  END;
END;

CREATE PROCEDURE upgrader_cql_install_baseline_schema()
BEGIN
  CREATE TABLE IF NOT EXISTS t4(
    id LONG_INT PRIMARY KEY AUTOINCREMENT,
    data BLOB
  );
  
END;
-- declared upgrade procedures if any

-- drop all the triggers we know
CREATE PROCEDURE upgrader_cql_drop_all_triggers()
BEGIN
  CALL upgrader_cql_drop_legacy_triggers();
END;

CREATE PROCEDURE upgrader_perform_needed_upgrades()
BEGIN
  DECLARE column_exists BOOL NOT NULL;
  DECLARE facet_version LONG INTEGER NOT NULL;
  DECLARE schema_version LONG INTEGER NOT NULL;

  -- fetch current schema version --
  CALL upgrader_cql_get_facet_version('cql_schema_version', schema_version);

  -- check for downgrade --

  IF schema_version > 0 THEN
    SELECT 'downgrade detected' facet;
  ELSE

    -- save the current facets so we can diff them later --
    CALL upgrader_save_cql_schema_facets();
    -- dropping condemned or changing triggers --
    CALL upgrader_cql_drop_all_triggers();

    ---- install baseline schema if needed ----

    CALL upgrader_cql_get_version_crc(0, schema_version);
    IF schema_version != 4355262830921719841 THEN
      CALL upgrader_cql_install_baseline_schema();
      CALL upgrader_cql_set_version_crc(0, 4355262830921719841);
    END IF;

    CALL upgrader_cql_set_facet_version('cql_schema_version', 0);
    CALL upgrader_cql_set_facet_version('cql_schema_crc', -5635641207918476938);

    -- finally produce the list of differences
    SELECT T1.facet FROM
      upgrader_cql_schema_facets T1
      LEFT OUTER JOIN upgrader_cql_schema_facets_saved T2
        ON T1.facet = T2.facet
      WHERE T1.version is not T2.version;
  END IF;
END;

CREATE PROCEDURE upgrader()
BEGIN
  DECLARE schema_crc LONG INTEGER NOT NULL;

  -- create schema facets information table --
  CALL upgrader_create_cql_schema_facets_if_needed();

  -- fetch the last known schema crc, if it's different do the upgrade --
  CALL upgrader_cql_get_facet_version('cql_schema_crc', schema_crc);

  IF schema_crc <> -5635641207918476938 THEN
    -- save the current facets so we can diff them later --
    CALL upgrader_perform_needed_upgrades();
  ELSE
    -- some canonical result for no differences --
    SELECT 'no differences' facet;
  END IF;
END;

out/cql --in upgrader.sql --cg u.h u.c

cc -E -x c x.sql -DLONG_INT=integer | sed "/^#/d"

  CREATE TABLE t4(
    id integer PRIMARY KEY AUTOINCREMENT,
    data

query_plan_test() {
  echo '--------------------------------- STAGE 15 -- TEST QUERY PLAN'

  # linux build of sqlite doesn't have explain query plan
  echo run query plan in c

sqlite> create table foo(id integer);
sqlite> explain query plan select * from foo;
0|0|0|SCAN TABLE foo (~1000000 rows)

sqlite3/bionic-updates,bionic-security 3.22.0-1ubuntu0.4 amd64
  Command line interface for SQLite 3

--------------------------------- STAGE 15 -- TEST QUERY PLAN
C preprocessing
semantic analysis
codegen query plan
semantic analysis
validating test
Verification results: 1 tests matched 32 patterns of which 0 were errors.
validating query plan codegen
  computing diffs (empty if none)
validate udf test
validating udf codegen
  computing diffs (empty if none)
build query plan c code
compile query plan code
cc -I./ -Iout -g -std=c99 -D_Nullable= -D_Nonnull= -c query_plan_test.c -o out/query_plan_test.o
cc -I./ -Iout -g -std=c99 -D_Nullable= -D_Nonnull=   -c -o out/query_plan.o out/query_plan.c
cc -I./ -Iout -g -std=c99 -D_Nullable= -D_Nonnull=   -c -o out/udf.o out/udf.c
cc -I./ -Iout -g -std=c99 -D_Nullable= -D_Nonnull= -o out/query_plan_test out/query_plan_test.o out/cqlrt.o out/query_plan.o out/udf.o -lsqlite3 -pthread -ldl
run query plan in c
out/query_plan_test returned a failure code
failed populating query 9
sqlite error: near "ON": syntax error
--------------------------------- FAILED