Giter Club home page Giter Club logo

Comments (4)

ashoemaker avatar ashoemaker commented on June 17, 2024

👍

from tweaks.

grp avatar grp commented on June 17, 2024

Sorry, I totally missed this one. I'll take a look as soon as I have time and add a unit test. Or, if you want to send a pull request :)

from tweaks.

itsthejb avatar itsthejb commented on June 17, 2024

Hi there. Had a bit of a chance to look into this today, and appears that this is non-trivial, since FBTweakValue() is actually implemented using _Generic(). However, I notice the inclusion of extern "C" {..., so I'm a bit confused as to whether or not this was expected to work or not.

It seems to me that getting this to work with ObjC++ would require reimplementing FBTweakValue() to use C++ constructs rather than _Generic(). In which case, considering it's possible to just expose Tweaks values from another non-C++ compilation unit, I would say this isn't worthwhile. In which case, perhaps it would be better to just go with:

#ifdef __cplusplus
#error C++ unsupported error, etc... However, you can expose values from blah, blah, blah helpful advice
#endif

...but I'd be interested to know if this was intended to work first.

from tweaks.

itsthejb avatar itsthejb commented on June 17, 2024

I did a quick PR if you think it's ok to just go with the build error "solution".

from tweaks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.