Giter Club home page Giter Club logo

Comments (10)

fabiomcosta avatar fabiomcosta commented on March 28, 2024

I agree this should be available and documented.

from react.

vjeux avatar vjeux commented on March 28, 2024

👍

from react.

radebrecht avatar radebrecht commented on March 28, 2024

+1 to that. At the moment adding the missing svg tags is a bit pokey.

from react.

zpao avatar zpao commented on March 28, 2024

FWIW, this won't help the JSX transformer which maintains it's own list of tags it recognizes and converts to React.DOM.*

from react.

sverrejoh avatar sverrejoh commented on March 28, 2024

@zpao I'm sure the custom DOM nodes can be imported into the local scope, so when JSX converts them (like it does with React components), it will just work.

In addition to SVG tags (which can all be supported by React eventually) there is also custom tags needed by legacy code, or proprietary systems. This is tags that will never be a part of React, and the only obvious alternative now (beside patching React) is to use dangerouslySetInnerHTML, which is a little tedious.

So I'd be all for having a clean way to expand the supported DOM nodes with something like createDOMComponent.

from react.

zpao avatar zpao commented on March 28, 2024

@sverrejoh As somebody who works on React, I'm saying that merely exposing this function doesn't add the tags to the JSX list. So if you want to be able to run jsx on your code and have new tags be converted to React.DOM.newtag then we need to do more.

React: https://github.com/facebook/react/blob/master/src/core/ReactDOM.js
JSX: https://github.com/facebook/react/blob/master/vendor/fbtransform/transforms/xjs.js

from react.

cemerick avatar cemerick commented on March 28, 2024

There's two separate issues here: allowing people to easily produce components corresponding to nonstandard tags, and making it so that jsx knows about such things for a given project/codebase.

As someone that doesn't use jsx (and likely never will), addressing the former by simply exporting createDOMComponentClass would be a big immediate win for me, and may be for others in the same position as well. The latter issue is surely more challenging, but can be tackled later if deemed worthwhile.

from react.

syranide avatar syranide commented on March 28, 2024

@zpao @petehunt @sebmarkbage While I imagine 0.12 will make this happen, it does not address the issue of related attributes/properties that wouldn't be whitelisted right?

from react.

sebmarkbage avatar sebmarkbage commented on March 28, 2024

Correct, we'll get there for attributes too though.

from react.

zpao avatar zpao commented on March 28, 2024

At this point I think it's safe to say we'll never do this.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.