codegen - javaPackageName is ignored with includesGeneratedCode and react-native codegen about react-native HOT 8 OPEN

This is (sadly) a known bug. The issue is happening regardless of you using includesGeneratedCode or not.

I have an internal ticket to work on this.
Sadly fixing it would be a breaking change for every codegen user so we're being a bit caution on when we should fix.

from react-native.

This is definitely a bug. I'll take a look

from react-native.

@dmytrorykun opened issue #45112

from react-native.

We've been hitting this issue in react-native-builder-bob. I've added a script to patch this behavior there. You can find the script here
For folks who want to use this, when we land this in bob, you will be able to call it with --target codegen and it should generate the codegen specs and patch this.

from react-native.

@cortinico thanks much.

Another issue is that outputDir is not relative to package root, but to cwd. So in the reproducer if run:

cd ReproducerApp
npx react-native codegen --path ../RTNCalculator --platform android

it generates into ./android/codegen which is ReproducerApp/android/codegen instead of ../RTNCalculator/android/codegen.

RTNCalculator/package.json:

    "includesGeneratedCode": true,
    "outputDir": {
      "android": "android/codegen"
    }

Is this a bug? Shall I open a separate issue for it?

from react-native.

it generates into ./android/codegen which is ReproducerApp/android/codegen instead of ../RTNCalculator/android/codegen.

mmm I'm not sure this follows to your previous statement.
If as you said, the path is relative to cwd (being ./ReproducerApp in your example), then stuff should be generated inside:

./RTNCalculator/android/codegen

no?

from react-native.

mmm I'm not sure this follows to your previous statement. If as you said, the path is relative to cwd (being ./ReproducerApp in your example), then stuff should be generated inside:

./RTNCalculator/android/codegen

no?

Sorry if I wasn't clear. I'd expect

"includesGeneratedCode": true,
    "outputDir": {
      "android": "android/codegen"
    }

to always generate into RTNCaclulator/android/codegen so always into the lib, but if I run from the app directory it creates new folder in the app

cd ReproducerApp
npx react-native codegen --path ../RTNCalculator --platform android

it generates into ReproducerApp/android/codegen

ReproducerApp % ls -la android/codegen/java/com/rtncalculator 
total 8
drwxr-xr-x  3 boga  staff    96 Jun 20 14:24 .
drwxr-xr-x  4 boga  staff   128 Jun 20 14:24 ..
-rw-r--r--  1 boga  staff  1130 Jun 20 14:24 NativeRTNCalculatorSpec.java

from react-native.

@dmytrorykun can help you more here as he implemented the react-native codegen command. But yes this is probably a separate bug which needs a separate issue

from react-native.