Giter Club home page Giter Club logo

Comments (4)

mrazauskas avatar mrazauskas commented on July 19, 2024

The link you provided is pointing to a dev dependency. This is not Jest dependency, so it is incorrect to say that "Jest depends on node-notifier".

In this case node-notifier is simply used for testing the code base. More precisely, the node-notifier package is used to test the notify configuration option.

from jest.

hyandell avatar hyandell commented on July 19, 2024

Totally understood that it's not a runtime dependency, and that we're into semantics where I would consider any runtime, test, dev dependencies to all be dependencies [especially if they have any opportunity to affect the contents of the release bytes].

All good if this isn't a concern for Jest, I'm not here to push for any change that isn't wanted :)

from jest.

SimenB avatar SimenB commented on July 19, 2024

Yeah, we don't ship it (it's an optional peer (

"node-notifier": {
)), so I think we're alright. But just to be safe, let's see if @bensternthal can tell us 😃

Also, assuming since we don't have it as a dep ourselves it's fine, would it have been an issue? I really don't know how these things work 😅

from jest.

hyandell avatar hyandell commented on July 19, 2024

With much embarrassment, I think at this stage this is a case of my inexperience with npm (I've more of a Maven background) and not identifying that I was looking at an older version of Jest in the dependency tree prior to your moving to peerDependencies. I think you've already fixed this in the later versions :/

[I think this can be closed, but leaving open so a Jest maintainer can have closure and, y'know, call me a fool etc :) ]

from jest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.