Inline requires throwing errors on existing node modules about fbjs HOT 4 CLOSED

We are using the inline-require transform for unit tests to do lazy mocking and to be able to use top-level requires in jest unit tests to be more consistent with how we write regular modules. We shouldn't be applying it to third-party code that doesn't need transforms to be applied, I'll fix the issue in react-native.

The issue is:

var A = require('A');

A = Foo;

gets transformed to

require('A') = Foo;

from fbjs.

Makes sense! That would be super weird. Thanks for the explanation.

from fbjs.

@cpojer I've found another case where this transform is being applied to vendored code. Trying to run xcode integration tests in react-native 0.12 or 0.13, on circle ci results in the following from the packager:

{"message":"TransformError: /Users/distiller/shopify-native/node_modules/react-native/node_modules/react-tools/src/shared/vendor/performance/performanceNow.js: /Users/distiller/shopify-native/node_modules/react-native/node_modules/react-tools/src/shared/vendor/performance/performanceNow.js: Cannot assign to a require(...) alias, performance. Line: 21","type":"TransformError","errors":[{}]}

from fbjs.

I don't know how the xcode integration tests are being run but they need to manually ignore performanceNow for now, just like the jest preprocessor in react-native does. @balpert will be upgrading react-native to react 0.14 soon, so this issue will go away. Also cc @ide in case he knows anything about circleci setup.

from fbjs.