Comments (9)
I think the problem with ./
is it doesn’t work for single page apps with routing.
For example when you load localhost:3000/products
, you don’t want to load products/main.js
.
Since most React apps are single page apps (and most SPAs use HTML5 history over hashes these days), I think we we’ll have to stick with requiring a server for the bundle. But maybe I’m wrong.
from create-react-app.
@vjeux Thanks for the response!
Yea so currently if I am in a gh-pages branch and run:
fs.readdirSync("./").forEach(toBeErased => {
if (toBeErased === "react-gh.js" || toBeErased === "build" || toBeErased === ".git" || toBeErased === "node_modules" | toBeErased === "src") {
} else {
fs.unlinkSync(toBeErased)
}
})
fs.readdirSync('build').forEach(file => {
fileContents = fs.readFileSync(`build/${file}`)
fs.writeFileSync(file, fileContents)
})
Everything looks fine, but the html is clueless haha.
I got it to work perfectly after manually changing the paths :)
from create-react-app.
@gaearon Never thought about the routing part. Good catch
from create-react-app.
Sorry, deleted my response. #21 is also talking about the same issue
from create-react-app.
@vjeux Is that just for the package.json or does that include the src for the script and link tags?
from create-react-app.
Ok it seems this is being covered in multiple Issues. I couldn't tell from the titles!
Feel free to keep open or close
from create-react-app.
Let’s continue in #21.
from create-react-app.
GH Pages should work with 0.2.0 alpha, here's how to test it: #190
from create-react-app.
Fantastic! Thanks for the update
from create-react-app.
Related Issues (20)
- npm error code E404 npm error 404 Not Found - GET https://registry.npmjs.org/creat-react-app - Not found npm error 404 npm error 404 'creat-react-app@*' is not in this registry. npm error 404 npm error 404 Note that you can also install from a npm error 404 tarball, folder, http url, or git url.
- cannot build projects when cwd contains a pathname with ! HOT 1
- Npx create-react-app: 8 vulnerabilities (2 moderate, 6 high) HOT 8
- Create react app HOT 1
- login issue
- my sign in not working
- HMR not working
- [email protected]
- "npx create-react-app" doesn't generate src or public folders HOT 1
- Usage override/workaround/hack with ESLint 9
- Frontend Host doesn't match the current host in the browser, so it's probably incorrect. Links in emails and file downloads from the API will not work. Click here to update. HOT 1
- [https://newsroom.spotify.com/news/](https://deezer.page.link/fCBsxrTRUZvKbLkA8) HOT 3
- react-scripts/v/5.1.0-next.14 contains multiple security vulnerabilities for inner modules
- Issue in creating react app HOT 4
- cra打包路由切换FiberRootNode会新增,webpack打包就不会 HOT 1
- Error -4048 and Error -4058 and ENOENT, HOT 1
- Des erreurs apres installation de mui sur un projet React 18.0.0 ou supérieur HOT 1
- del proyecto
- how i can run react program in vs code HOT 4
- React JS HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-react-app.