Giter Club home page Giter Club logo

Comments (3)

bernardbeckerman avatar bernardbeckerman commented on June 10, 2024 1

Thanks for pointing this out! I'll put up a change to rectify this : )

from ax.

basarkutukcu avatar basarkutukcu commented on June 10, 2024

I actually commented on the PR but I think it's hard to see the comment there. I am copying the comment below. @bernardbeckerman What do you think?

Is this the correct fix for the problem? I was expecting a change to use get_MOO_EHVI instead of Models.BOTORCH_MODULAR as following.

      ehvi_model = get_MOO_EHVI(
          experiment=ehvi_experiment,
          data=ehvi_data,
      )

from ax.

bernardbeckerman avatar bernardbeckerman commented on June 10, 2024

This new BOTORCH_MODULAR model type replaced the legacy get_MOO_EHVI in #1982 and should be used in its place going forward. Please let me know if you have further questions!

from ax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.