Giter Club home page Giter Club logo

Comments (4)

mgrange1998 avatar mgrange1998 commented on May 18, 2024

Yes, looking through the ChoiceParameter construction code it looks like there isn't yet a way to pass "sort_values" with a dict, thanks for bringing this to our attention.

If I am understanding correctly, you are passing a "ChoiceParameter" object into "parameter_from_json", and line 280 is erroring because ChoiceParameter is not an iterable object. This is expected, as parameter_from_json is meant to convert JSON objects to Parameter objects.
Since you are now constructing the ChoiceParameter you do not need to pass it into parameter_from_json- you can instead use the ChoiceParameter directly. Let me know if this helps!

from ax.

Runyu-Zhang avatar Runyu-Zhang commented on May 18, 2024

Thanks for the tips mgrange1998. But I guess my issue was that when I construct a list of "ChoiceParameter" using for loop, like:
list_choice_parameters = []
for parameter in all_parameters:
list_choice_parameters.append(ChoiceParameter(name = parameter,
parameter_type = ParameterType.FLOAT,
values =[x1, x2, ...],
is_ordered = True,
sort_values = False)
)
and then pass list_choice_parameters to ax_client.create_experiment(name = name,
parameters = list_choice_parameters,
objectives = objectives
)
this is throwing an error TypeError: argument of type 'ChoiceParameter' is not iterable

Instead, if I append dictionaries to "list_parameters=[]", and then pass to ax_client.create_experiment(), it is fine, but then the warning comes: sort_values is not specified for ChoiceParameter "xxx". Defaulting to True for parameters of ParameterType FLOAT. To override this behavior (or avoid this warning), specify sort_values during ChoiceParameter construction.
Hopefully it makes sense.

from ax.

mgrange1998 avatar mgrange1998 commented on May 18, 2024

Hello again- that makes sense to me. I have a pull request up which will fix your issue by allowing you to specify "sort_values" in the input dictionary #2231
Once this lands, you'll be able to specify "sort_values" explicitly to stop the UserWarning from appearing. Let me know if you have any other questions!

from ax.

Runyu-Zhang avatar Runyu-Zhang commented on May 18, 2024

Nice. Thank you!

from ax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.