configuring run ports via external properties is limiting about docker-maven-plugin HOT 3 CLOSED

so i thought about this a little more this morning and realized this doesn't account for exposing ports as part of building the image although i still think this works, the property handler would just need to be a bit smarter and know if it saw an entry w/o any colons, it should be used in the build process.

from docker-maven-plugin.

The example above can be already written as

docker.ports.5678 = 8080
docker.ports.0.0.0.0\:80 = 80
docker.ports.host.port = 22

but you are right, this doesn't look very nice. BTW, if you are using these properties in property files you need to escape colons, too.

If you use properties for building docker images, mapping likes those above are taken into account (in this case 8080, 80 and 22 are exposed). If I understand you right, you want also expose a lonely port (without any colon). Do you have a use case where an exposed port should not be exported during the integration test ?

BTW, for the env part there also a limitation: With docker.env properties you set the environment for building and running an image (which is also not optimal, of course). One could add docker.envbuild and docker.envrun for environment variables which are set only for the building and running, respectively (and docker.env for variables to be set in both cases).

Since the property stuff is not yet released, if you like you can go ahead and adapt PropertyConfigHandler for using ports as a list ....

from docker-maven-plugin.

Any thoughts about this ? I want to get this in into 0.10.5 right now because it's a new feature.

from docker-maven-plugin.