Import external CSS about django-admin-interface HOT 7 CLOSED

@zuck thanks for the suggestion, I think it is an useful feature and it could be extended to external js too.
I will add it in the next release, if you have any other idea feel free to suggest it.

from django-admin-interface.

Ping here! I could try making a PR if that helps.

from django-admin-interface.

@merwok as you can see here there is an old unused field that in the past was used to store custom extra css.
The textarea fields containing the css/js code could work, but it is terrible to have working code pasted in a textarea (like many systems does).

Now the necessity seems to have the possibility to upload a custom css file and why not, also a custom js file.

The best solution would be to add an additional model with a css/js file using a foreign key to the theme, but I think that this solution would go to over engineering the db for doing a simple thing. So, I would add two fields to the theme model: extra_css and extra_js (with file extension validator).

Let me know what do you think about it.

from django-admin-interface.

I think I misunderstood the original request!

I don’t want to import extra CSS; I already do customizations that I need (mostly on object add/edit page) with extra JS and CSS in overriden admin/change_form.html templates. What I’d like is to move all the admin-interface CSS from the HTML template into a CSS template, so that the HTML pages only need link rel=stylesheet. It would make the source shorter (good for view source!) and let the browser cache the stylesheet (using the appropriate cache headers based on a checksum or version, for invalidation).

from django-admin-interface.

There should be no inline javascript/css at all. It is better to not have anything inline to follow content security policy best practices.

from django-admin-interface.

@9mido see #93

from django-admin-interface.

@zuck the solution suggested by @merwok solves your problems?

If not, could you be more specific about what you would like to do but you can't do?

Frankly it is my intention to close this issue because I don't want to add some potentially dangerous fields (a user with theme permissions could inject malicious code that would be executed by all users in all pages).

from django-admin-interface.