Giter Club home page Giter Club logo

Comments (6)

fabianmichael avatar fabianmichael commented on May 31, 2024

Bonjour encore!
C'ést une problème de PHP-Typography …
(okay, it has been a while since I’ve been talking or writing French … ;-) )

Basically, Kirby-Typography is a port of the wp-Typography, so you should open an issue in that repository in this case.

from kirby-typography.

fabianmichael avatar fabianmichael commented on May 31, 2024

But If you encounter any issues with my plugin, free to discuss them here :-)

from kirby-typography.

mundschenk-at avatar mundschenk-at commented on May 31, 2024

So you would like to have Les « courants ... as the output? Generally, PHP_Typography tries not to interfere with any "smart quotes" that are already present in the text, on the assumption that if they are there, the content writer intended them exactly like this.

from kirby-typography.

fabianmichael avatar fabianmichael commented on May 31, 2024

Makes sense, I agree here with @mundschenk-at on this. Otherwise, you could end with a lot of unexpected behaviour. Think, it should stay like that.

@fvsch If this is really an issue, you should be able to fix it with a kirbytext::$post filter.

from kirby-typography.

fvsch avatar fvsch commented on May 31, 2024

If this is really an issue, you should be able to fix it with a kirbytext::$post filter.

Yes, it's a real issue we have on a project with 80 articles or pages being copied over from simple Word documents. Quotation marks in those documents are always « quoted text », as is the default for Word set up with French settings.

I have no problem with writing a fix on our side (already did this in the project), but I do believe it should be a part of PHP_Typography, so I've argued my point over there. :)

from kirby-typography.

mundschenk-at avatar mundschenk-at commented on May 31, 2024

I've just added a branch that includes a fix for this issue.

from kirby-typography.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.