Support 32bit systems about kirby-imageset HOT 9 CLOSED

Thanks for pointing this out!

Do you have an idea how to work around this on 32 bit systems?

from kirby-imageset.

a dirty hack would be to use abs() or use a "proper" hashing method ;) Why so complicated with hexdec and base 16?

from kirby-imageset.

The hash is actually encoded in base62 (like base64, but without "/" and "="). The sole reason for this is, that hashes are much shorter while keeping a good entropy. However, it cannot stay like this, so I’ll try to find a solution as soon as possible. This will probably take a few days, as my schedule does not leave much room for this week.

from kirby-imageset.

md5 is a hash which could be used (or a substring of it) and you are already making use of it but still I wonder why you do an extra hexdec and the other stuff...

from kirby-imageset.

md5 uses only a-f0-9 as characters. My hash function uses a-zA-Z0-9. The reason is just to get shorter hashes, which do not waste bytes and look more readable on the other hand.

I’ll make a branch with a fixed hash function soon, so you can test on your 32 bit system (setting up a VM would take to long just for this sole issue). If you can confirm that it works, I’ll integrate that into master. Does this sound good for you?

from kirby-imageset.

sounds great!

from kirby-imageset.

Hey @simonschaufi, I’m going on vacation for the rest of the week and couldn’t manage to fix that bug before. But be sure that I did not forget about it. Will take care of that when I’m back at the desk.

from kirby-imageset.

Hey @simonschaufi, I finally decided to use md5 hashes instead of base62, as there does not seem to be an easy soluation that’s available on all PHP installations. Updates code is in the repo (master branch), but not part of an official release yet, though tested it on my local (64 bit) machine and it worked fine. Please try if it also work for you, then I’ll tag it as an official release.

from kirby-imageset.

Great! Unfortunatelly my good old 32 bit windows gave up a few weeks ago with a hardware damage and so I can't test right now but from my point of view it should work.

from kirby-imageset.