Giter Club home page Giter Club logo

Comments (3)

zkulbeda avatar zkulbeda commented on May 9, 2024 3

I suggest returning special object that represents validation error just like ValiError. It has special tag to distinguish it. For user convenience, add error method into info context agument in parse and pipeline functions

// example
const StringSchema = string([
  (input, ctx) => {
    if (input.length > 10) {
      return ctx.error(
        {
          validation: "custom",
          origin: "value",
          message: "Invalid length",
          input, // can be spreaded inside `error`
        },
      );
    }
    return input;
  },
]);

const _ErrorTag = Symbol();

function isError(obj: unknown): obj is Issue {
  return obj != null && typeof obj === "object" && obj[_ErrorTag] === _ErrorTag;
}

function createContext(info) {
  return {
    ...info,
    error: (errorObj: Issue) => ({
      [_ErrorTag]: _ErrorTag,
      ...info,
      ...errorObj,
    }),
  };
}

// executePipe
for (const action of pipe) {
  const outputOrError = action(output, createContext(info));
  if (isError(outputOrError)) {
    if (info.abortEarly || info.abortPipeEarly) {
      return error;
    }
    issues.push(outputOrError);
  } else output = outputOrError;
}

// parse method 
function parse<TSchema extends BaseSchema>(
  schema: TSchema,
  input: unknown,
  info?: Pick<ParseInfo, 'abortEarly' | 'abortPipeEarly'>
): Output<TSchema> {
  const result = schema.parse(input, createContext(info));
  if(isError(result)) throw new ValiError(result) // prevent breaking changes
  return result;
}

from valibot.

fabian-hiller avatar fabian-hiller commented on May 9, 2024 1

Thank you for this insight. Do you have an idea how the implementation could look like here? With a global object or array? Or a parameter that is passed through and modified directly?

from valibot.

fabian-hiller avatar fabian-hiller commented on May 9, 2024

Thank you for the code example! I will give it some thought.

from valibot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.