MsSQL Limit Clause about pdo HOT 4 CLOSED

Nice work on this library. It's one of the best standalone query builders I have seen on packagist. This issue should be fairly simple to fix in short term. If most of the private members and functions in SelectStatement were changed to protected, I could extended it and override getSelect() to implement the MsSQL limit. The same sort of thing will probably apply to other classes. The long term solution here is to have a set of interfaces that are implemented for each RDBMS flavor and specified via the config, but that will take quite a bit more effort.

from pdo.

Thanks @kwhat! I like your idea making Slim-PDO more extendable. The long term solution you're suggesting might be something more for a V2, but changing some members and functions to protected should do the job for now without breaking things indeed. 😄

from pdo.

Yah, thats what I figured. I can put in a Pull Request at some point today.

from pdo.

Perfect! 👌

from pdo.