Giter Club home page Giter Club logo

Comments (14)

 avatar commented on May 27, 2024 3

I can confirm this in Linux Mint. ls -l gives

lrwxrwxrwx 1 rsholmes rsholmes 41 Nov 14 14:28 file -> '/home/rsholmes/test/foo bar/baz/test/file'

while 'eza -l` gives

lrwxrwxrwx - rsholmes 14 Nov 14:28 'file -> /home/rsholmes/test/foo bar/baz/test'/file

Placement of both quotes makes no sense in eza. ls is reasonable.

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

As I don't have a mac I can't test this, but can you tell me where the quote should be in your opinion

from eza.

moonfruit avatar moonfruit commented on May 27, 2024

@MartinFillon Yes, I think @holmesrichards is right.

This one is reasonable.

lrwxrwxrwx 1 rsholmes rsholmes 41 Nov 14 14:28 file -> '/home/rsholmes/test/foo bar/baz/test/file'

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

Okay it clearly needs to be fixed

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

I am either lucky or something, but I cannot reproduce i, can you, anyone that encounter it, precise the commands used to generate the files, the arguments of eza, and the env vars used in the process whatever they are if they are not colors related.

from eza.

 avatar commented on May 27, 2024
cd /home/rsholmes
mkdir quotes
cd quotes/
mkdir x\ y
mkdir x\ y/z
touch x\ y/z/u
ln -s /home/rsholmes/quotes/x\ y/z/u ./v
eza -l

Output:

lrwxrwxrwx - rsholmes 15 Nov 18:09 'v -> /home/rsholmes/quotes/x y/z'/u
drwxrwxr-x - rsholmes 15 Nov 18:09 'x y'

No relevant non colors env vars, I believe.

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

thanks

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

Just tested and on eza v0.15.3 I cannot reproduce it, on eza compiled from main too

from eza.

 avatar commented on May 27, 2024

I'm seeing it in 0.15.3, Linux Mint, output as above. Including in a different user account that has no eza/exa related environment variables.

from eza.

moonfruit avatar moonfruit commented on May 27, 2024

I use homebrew bottled eza, and no eza/exa related environment variables.

from eza.

 avatar commented on May 27, 2024

Some more tests:

lrwxrwxrwx - rsholmes 15 Nov 19:30 'v -> /home/rsholmes/quotes/x y/z'/u
drwxrwxr-x - rsholmes 15 Nov 21:35 'x y'
lrwxrwxrwx - rsholmes 15 Nov 21:35 'xyc -> /home/rsholmes/quotes/x y'/c
lrwxrwxrwx - rsholmes 15 Nov 21:32 xyl -> /home/rsholmes/quotes/'x y'
lrwxrwxrwx - rsholmes 15 Nov 21:34 'xyzab -> /home/rsholmes/quotes/x y/z'/'a b'
lrwxrwxrwx - rsholmes 15 Nov 21:37 'xyzijk -> /home/rsholmes/quotes/x y/z/i/j'/k
lrwxrwxrwx - rsholmes 15 Nov 21:33 'xyzl -> /home/rsholmes/quotes/x y'/z
lrwxrwxrwx - rsholmes 15 Nov 21:39 'xyzpqr -> /home/rsholmes/quotes/x y/z/p q'/r
lrwxrwxrwx - rsholmes 15 Nov 21:41 'xyzpqst -> /home/rsholmes/quotes/x y/z/p q'/'s t'

It seems the crucial thing is that there's a path component containing a space which is not the final path component. If the only space is in the final component then eza puts the quotes around that component, which is not unreasonable. But if there's a space further up, it puts quotes before the link name and after the penultimate path component, before the last slash (regardless of which component has the space). If there are spaces in both locations it does both.

ls consistently puts quotes around the whole path:

total 4
lrwxrwxrwx 1 rsholmes rsholmes   29 Nov 15 19:30  v -> '/home/rsholmes/quotes/x y/z/u'
drwxrwxr-x 3 rsholmes rsholmes 4096 Nov 15 21:35 'x y'
lrwxrwxrwx 1 rsholmes rsholmes   27 Nov 15 21:35  xyc -> '/home/rsholmes/quotes/x y/c'
lrwxrwxrwx 1 rsholmes rsholmes   26 Nov 15 21:32  xyl -> '/home/rsholmes/quotes/x y/'
lrwxrwxrwx 1 rsholmes rsholmes   31 Nov 15 21:34  xyzab -> '/home/rsholmes/quotes/x y/z/a b'
lrwxrwxrwx 1 rsholmes rsholmes   33 Nov 15 21:37  xyzijk -> '/home/rsholmes/quotes/x y/z/i/j/k'
lrwxrwxrwx 1 rsholmes rsholmes   27 Nov 15 21:33  xyzl -> '/home/rsholmes/quotes/x y/z'
lrwxrwxrwx 1 rsholmes rsholmes   33 Nov 15 21:39  xyzpqr -> '/home/rsholmes/quotes/x y/z/p q/r'
lrwxrwxrwx 1 rsholmes rsholmes   35 Nov 15 21:41  xyzpqst -> '/home/rsholmes/quotes/x y/z/p q/s t'

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

Can no longer reproduce on the last eza build and builded from git. Can you confirm fixed ?
20231202_19h40m02s_grim

from eza.

moonfruit avatar moonfruit commented on May 27, 2024

It doesn't look like that's been fixed either from the pictures you posted. And on my computer, eza 0.16.2 not fixes this

from eza.

MartinFillon avatar MartinFillon commented on May 27, 2024

Oh okay it has been fixed on the end, not at the start didnt get fixed gonna see that

from eza.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.