Comments (9)
Are you using the latest version of the script? I encountered the same problem a few days ago and pushed a fix.
from savesvgaspng.
Yep, I cloned the repo just today and copied the js file across.
from savesvgaspng.
Does the latest version of the code produce this error?
from savesvgaspng.
I'm getting an error too, maybe it's related. I just got the file from the master branch and I'm seeing this error:
Error: Failed to execute 'querySelectorAll' on 'Element': '[ng:cloak], [ng-cloak], [data-ng-cloak], [x-ng-cloak], .ng-cloak, .x-ng-cloak, .ng-hide:not(.ng-animate)' is not a valid selector.
Tried this on a svg generated through a directive in angular (in case you were wondering about where does those names come from).
Invoking line:
saveSvgAsPng(document.getElementById("diagram"), "diagram.png", 3);
from savesvgaspng.
@lobo-tuerto I don't think this is related. The problem is that document.querySelectorAll
doesn't recognize [ng:cloak]
, which is used in a CSS rule.
There's probably a better way to handle styles than how the script currently does it. Please create a separate issue and I'll take a closer look when I have a chance.
from savesvgaspng.
Done. Thank you.
from savesvgaspng.
I'm closing this since I haven't heard any more about the original problem. If anyone sees TypeError: Cannot read property 'length' of null
, feel free to re-open.
from savesvgaspng.
I'm getting this error. In my case, it is line 43:
https://github.com/exupero/saveSvgAsPng/blob/gh-pages/saveSvgAsPng.js#L43
The stylesheet that has cssRules == null
in my case is a Google Font. So maybe a simple check if (rules) ...
before the for loop could fix this.
from savesvgaspng.
I ran into a similar issue as @honi above, but with a Google Chart. While Google Charts has the ability to create a PNG, that function only works for their core charts. I have a Sankey chart generated with Google Charts that gave me the same "Cannot read property 'length' of null" error. Didn't have the same issue while creating a Sankey using D3.js.
Just sent a pull request with my suggested patch. To replicate, I used a sample Sankey chart from the code on the Google Charts Sankey page. Adding the null check resolves the issue. I wonder if Google has a similar cssRules == null, as @honi mentions?
from savesvgaspng.
Related Issues (20)
- when <svg> has <img>,con't show the imge in the png HOT 3
- Size of downloaded image varying according to the zoom level of browser HOT 1
- Only half of the SVG is rendered
- saveSvgAsPng without css styleSheets, modifyCss dosen`t work, who can tell me how to use modifyCss HOT 3
- saveSvgAsPng makes svg's image fill disappear (d3.js) HOT 9
- use to generate PNG on server? (solved: using sharp.js instead) HOT 2
- CSS rule breaks export? HOT 3
- i get this error ReferenceError: excludeUnusedCss is not defined HOT 1
- How to add a Google Font? HOT 3
- Uncaught (in promise) TypeError: Cannot read property 'width' of undefined at saveSvgAsPng.js:265 HOT 1
- ReferenceError: navigator is not defined (using Node.js) HOT 1
- How to use fonts in options parameter. HOT 3
- saveSvgAsPng is not capturing all the items inside svg tag
- HOW can i do, if the dataURl size > 2M
- some svgs not working on mobile safari
- Syntax error HOT 1
- svgAsPngUri working on browser but not android HOT 1
- Add/Update TypeScript type definitions
- HTMLElement or SVGElement in Chrome HOT 1
- problem with Canvg library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from savesvgaspng.