Giter Club home page Giter Club logo

Comments (9)

exupero avatar exupero commented on May 24, 2024

Are you using the latest version of the script? I encountered the same problem a few days ago and pushed a fix.

from savesvgaspng.

wooly avatar wooly commented on May 24, 2024

Yep, I cloned the repo just today and copied the js file across.

from savesvgaspng.

exupero avatar exupero commented on May 24, 2024

Does the latest version of the code produce this error?

from savesvgaspng.

lobo-tuerto avatar lobo-tuerto commented on May 24, 2024

I'm getting an error too, maybe it's related. I just got the file from the master branch and I'm seeing this error:

Error: Failed to execute 'querySelectorAll' on 'Element': '[ng:cloak], [ng-cloak], [data-ng-cloak], [x-ng-cloak], .ng-cloak, .x-ng-cloak, .ng-hide:not(.ng-animate)' is not a valid selector.

Tried this on a svg generated through a directive in angular (in case you were wondering about where does those names come from).

Invoking line:

saveSvgAsPng(document.getElementById("diagram"), "diagram.png", 3);

from savesvgaspng.

exupero avatar exupero commented on May 24, 2024

@lobo-tuerto I don't think this is related. The problem is that document.querySelectorAll doesn't recognize [ng:cloak], which is used in a CSS rule.

There's probably a better way to handle styles than how the script currently does it. Please create a separate issue and I'll take a closer look when I have a chance.

from savesvgaspng.

lobo-tuerto avatar lobo-tuerto commented on May 24, 2024

Done. Thank you.

from savesvgaspng.

exupero avatar exupero commented on May 24, 2024

I'm closing this since I haven't heard any more about the original problem. If anyone sees TypeError: Cannot read property 'length' of null, feel free to re-open.

from savesvgaspng.

honi avatar honi commented on May 24, 2024

I'm getting this error. In my case, it is line 43:
https://github.com/exupero/saveSvgAsPng/blob/gh-pages/saveSvgAsPng.js#L43

The stylesheet that has cssRules == null in my case is a Google Font. So maybe a simple check if (rules) ... before the for loop could fix this.

from savesvgaspng.

trhall avatar trhall commented on May 24, 2024

I ran into a similar issue as @honi above, but with a Google Chart. While Google Charts has the ability to create a PNG, that function only works for their core charts. I have a Sankey chart generated with Google Charts that gave me the same "Cannot read property 'length' of null" error. Didn't have the same issue while creating a Sankey using D3.js.

Just sent a pull request with my suggested patch. To replicate, I used a sample Sankey chart from the code on the Google Charts Sankey page. Adding the null check resolves the issue. I wonder if Google has a similar cssRules == null, as @honi mentions?

from savesvgaspng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.