Giter Club home page Giter Club logo

Comments (4)

SamWhitby avatar SamWhitby commented on August 28, 2024

I ran into the same issue where the xlink:href attribute was being repeated.
I changed line 18 to this
var href = image.getAttributeNS("http://www.w3.org/1999/xlink", 'href');
and line 34 to this
image.setAttributeNS("http://www.w3.org/1999/xlink", 'xlink:href', canvas.toDataURL('image/png'));
so the href attribute was set with the correct namespace.

from savesvgaspng.

danswick avatar danswick commented on August 28, 2024

I had the same issue. Changed both instances of xlink:href (lines 18 and 34) to just href and everything worked as expected.

@SamWhitby, I tested your solution and it worked as well and seems to be a better and more explicit solution. Thanks.

from savesvgaspng.

bastrapp avatar bastrapp commented on August 28, 2024

I had the same issue, both your solutions worked fine.

Thank you!

from savesvgaspng.

exupero avatar exupero commented on August 28, 2024

Should be fixed by #33. Let me know if you have any more trouble.

from savesvgaspng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.