Comments (2)
please checkout #2187 and the newly introduced BUILD_GIT_COMMIT_ID
env var. does this not solve the issue of building from source without git?
the cargo install gitui
problem to turning out with a nightly version string is a bit tricky. not sure if this can be fixed. maybe I have to reverse and pick the cargo package version by default and set nightly via env
from gitui.
please checkout #2187 and the newly introduced
BUILD_GIT_COMMIT_ID
env var. does this not solve the issue of building from source without git?
This would work. However, I don't want to introduce another manual step into the process of updating our packages. I'd have to look up the commit hash that corresponds to the tagged release for every new release, and I can't automate that. I could set BUILD_GIT_COMMIT_ID
to some garbage data, but that would just end up as garbage in gitui --version
:(
If the git commit hash cannot be determined, maybe it would be better to just exclude it from the format string? i.e. something like
if let Some(hash) = commit_hash {
format!("{} {} ({})", gitui_version, source_date, hash)
} else {
format!("{} {}", gitui_version, source_date)
}
the
cargo install gitui
problem to turning out with a nightly version string is a bit tricky. not sure if this can be fixed. maybe I have to reverse and pick the cargo package version by default and set nightly via env
Yeah, I'm not sure how to fix this either. Maybe set the version string to "nightly" only if the git commit hash can be determined and GITUI_RELEASE
is not set? That way a build from git could be made a "release" build, but builds from git would be "nightly" by default. I think you already set GITUI_RELEASE
in your github workflows, so those would not be affected.
from gitui.
Related Issues (20)
- Compare 2 branches history HOT 2
- Timeout after unsuccesful pushing to repo HOT 1
- Unknown Characters HOT 1
- Pre-commit hooks are executed only when launched from the git root HOT 2
- building on Pinebook Pro running Manjaro ARM HOT 7
- UI is unintelligible on WezTerm + Fish Shell + Catppuccin theme HOT 3
- Branching from a specific commit
- Colors and Themes
- How to push/pull with a self assigned certificate? HOT 1
- [BUG]: Does not support custom git config path via GIT_CONFIG_GLOBAL HOT 4
- Installing with cargo takes forever HOT 2
- Maintain FG colour in selection
- Disable syntax highlighting
- `line_break` in `theme.ron` is interpreted incorrectly
- Panic when starting from subfolder
- Use default shell for git-hooks instead of bash HOT 1
- Panic on request to unstage lines
- [Feature request] Add syntax highlight for diff view
- Default `--watcher` by "config ron" file
- Wrong binary size comparison in README.md HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitui.