Giter Club home page Giter Club logo

Comments (9)

malcolmbarrett avatar malcolmbarrett commented on August 21, 2024 1

I've got one more PR coming surrounding the way templates are handled that will close this

from rextendr.

clauswilke avatar clauswilke commented on August 21, 2024

That's mostly just my ignorance. Feel free to change. I'd rather have a cli dependency than usethis dependency.

from rextendr.

malcolmbarrett avatar malcolmbarrett commented on August 21, 2024

Ok, I'll prep a PR exploring that. Thanks!

from rextendr.

Ilia-Kosenkov avatar Ilia-Kosenkov commented on August 21, 2024

I just want to point out that here r-lib/usethis#956 hadley recommends to use {cli} instead of ui_* (at least that's how I understand his message). I suggest to use {cli} (see some crude examples in #65).

from rextendr.

malcolmbarrett avatar malcolmbarrett commented on August 21, 2024

Oh, great that you're already planning to import cli. Yes, there's some nice guidance here for writing usethis-like ui: https://cli.r-lib.org/articles/usethis-ui.html. I think limiting to cli makes sense for this use case.

from rextendr.

Ilia-Kosenkov avatar Ilia-Kosenkov commented on August 21, 2024

Please take into account this set of functions when adding {cli} support
https://github.com/extendr/rextendr/blob/main/R/ui.R

from rextendr.

malcolmbarrett avatar malcolmbarrett commented on August 21, 2024

Thanks! I had intended to that in this PR, so awesome 😎

I might continue waiting on this until #88/#70 are resolved as that directly affects the approach for this small issue

from rextendr.

malcolmbarrett avatar malcolmbarrett commented on August 21, 2024

FYI Now that this other work has settled, I'll try to get a PR up for this in the next day or two

from rextendr.

Ilia-Kosenkov avatar Ilia-Kosenkov commented on August 21, 2024

@malcolmbarrett,
Should this be closed or are there any other features you think should be implemented?

from rextendr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.