Giter Club home page Giter Club logo

Comments (4)

wesleytodd avatar wesleytodd commented on May 22, 2024 2

I think that for the minimum version, there's a different history, and we can establish a general rule before v5 is released

I agree we can set a rule, and as long as we keep to your point made in the "side note" (many of those packages are used outside of express and we cannot just change the supported node versions without a major bump) then I am good.

Is it ok to migrate them to github actions respecting the specified Node.js versions?
Migrating to GitHub Actions is the way.

Yep absolutely!!!

EDIT: I realize my original wording may have been confusing. I meant "they need to keep those node versions" not that we shouldn't improve them in general (like moving to actions for example). Sorry for the confusion!

from discussions.

carpasse avatar carpasse commented on May 22, 2024 1

@wesleytodd some repositories are still using travis Is it ok to migrate them to github actions respecting the specified Node.js versions?

from discussions.

UlisesGascon avatar UlisesGascon commented on May 22, 2024 1

All of those need to remain as is until we start updating them for major bumps. When we go to v5 for express most of those will likely land a few breaking changes as well as drop many node versions in the test matrix.

I think that for the minimum version, there's a different history, and we can establish a general rule before v5 is released, as it is an independent event.

  • As a general rule, any dependency or sub-dependency of Express v4 should at least support Node 0.10, as it is the minimum supported version for Express@4 today.
  • Any other project in the organization (including Express dependencies and sub-dependencies) that supports lower versions than 0.10 currently in their CI pipelines can serve as a reminder, just in case other projects or users depend on it. So in this context final handler supports [email protected] and mime-db supports Node@06
  • Once Express@5 is released, the minimum Node.js version will obviously change for the next major version of those libraries that the project depends on.

Side note: Dropping support for any specific Node.js version is considered a major semver change, while extending support to new ones is a minor semver change (AFAIK).

some repositories are still using travis Is it ok to migrate them to github actions respecting the specified Node.js versions?

Migrating to GitHub Actions is the way.

from discussions.

wesleytodd avatar wesleytodd commented on May 22, 2024

All of those need to remain as is until we start updating them for major bumps. When we go to v5 for express most of those will likely land a few breaking changes as well as drop many node versions in the test matrix.

@sheplu can you link to the current discsussion for the LTS strategy doc pr? I am not sure if it has moved from this one to the admin repo yet.

from discussions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.