Android versionCode bumped to semver? about standard-version-expo HOT 10 CLOSED

Ah, I think this a "cosmetic" issue only. Standard version uses the semver, not the actual value that was changed, in the logs. That means it's bumping your version with +1 when you use the android/increment bumper, but the output is the semver from package.json. This should be fixed anyway 😄 Could you try to do a test release, without pushing ofc, and see if the manifest value has the proper int?

from standard-version-expo.

Hmm, thanks for catching that one. I'll investigate this a bit further on Wednesday!

from standard-version-expo.

That is absolutely correct! It works :) Thanks! 🎉

Maybe update the DEV post as well with the /increment thing for android (I shared it with some people and they'll probably have the same issue).

Again, thanks for this.

from standard-version-expo.

What's your version config? For each version "property" you have to specify the correct version bumper. Does it look something like this?

module.exports = {
  bumpFiles: [
    {
      filename: 'package.json',
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/android/increment'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/ios'),
    },
  ],
};

(note the android/increment)

from standard-version-expo.

@byCedric aHA! I didn't get that from the dev link I added 😄

"Tries"

But even then, same output.

module.exports = {
  bumpFiles: [
    {
      filename: 'package.json',
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/ios'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/android/increment'),
    },
  ],
};

Gives me:

standard-version --dry-run "--release-as" "prepatch"

✔ bumping version in package.json from 1.0.0 to 1.0.1-0
✔ bumping version in app.json from 1.0.0 to 1.0.1-0
✔ bumping version in app.json from 3 to 1.0.1-0
✔ bumping version in app.json from 1.0.2 to 1.0.1-0
✔ created CHANGELOG.md
✔ outputting changes to CHANGELOG.md

from standard-version-expo.

Hmm, that's weird. Could you try a dry-run with the minor type? Something could be up with the prepatch calculation.

from standard-version-expo.

@byCedric Same thing. And now I've disabled everything besides the increment for test:

module.exports = {
  bumpFiles: [
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/android/increment'),
    }
  ],
};

Gives me:

standard-version --dry-run "--release-as" "minor"

✔ bumping version in app.json from 3 to 1.1.0
✔ created CHANGELOG.md
✔ outputting changes to CHANGELOG.md

from standard-version-expo.

Maybe relevant, but I'm using these versions:

    "standard-version": "^7.1.0",
    "standard-version-expo": "^1.0.3"

from standard-version-expo.

Thanks for the tip, I'll add it!

from standard-version-expo.

@byCedric Hey, it's me again. 😄

Prereleases do mess up the ios buildNumber a tad:

"buildNumber": "1.1.0-0",

Is this also a config issue?

from standard-version-expo.