Comments (10)
Ah, I think this a "cosmetic" issue only. Standard version uses the semver, not the actual value that was changed, in the logs. That means it's bumping your version with +1
when you use the android/increment
bumper, but the output is the semver from package.json
. This should be fixed anyway 😄 Could you try to do a test release, without pushing ofc, and see if the manifest value has the proper int?
from standard-version-expo.
Hmm, thanks for catching that one. I'll investigate this a bit further on Wednesday!
from standard-version-expo.
That is absolutely correct! It works :) Thanks! 🎉
Maybe update the DEV post as well with the /increment thing for android (I shared it with some people and they'll probably have the same issue).
Again, thanks for this.
from standard-version-expo.
What's your version config? For each version "property" you have to specify the correct version bumper. Does it look something like this?
module.exports = {
bumpFiles: [
{
filename: 'package.json',
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo'),
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo/android/increment'),
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo/ios'),
},
],
};
(note the android/increment
)
from standard-version-expo.
@byCedric aHA! I didn't get that from the dev link I added 😄
"Tries"
But even then, same output.
module.exports = {
bumpFiles: [
{
filename: 'package.json',
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo'),
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo/ios'),
},
{
filename: 'app.json',
updater: require.resolve('standard-version-expo/android/increment'),
},
],
};
Gives me:
standard-version --dry-run "--release-as" "prepatch"
✔ bumping version in package.json from 1.0.0 to 1.0.1-0
✔ bumping version in app.json from 1.0.0 to 1.0.1-0
✔ bumping version in app.json from 3 to 1.0.1-0
✔ bumping version in app.json from 1.0.2 to 1.0.1-0
✔ created CHANGELOG.md
✔ outputting changes to CHANGELOG.md
from standard-version-expo.
Hmm, that's weird. Could you try a dry-run with the minor
type? Something could be up with the prepatch calculation.
from standard-version-expo.
@byCedric Same thing. And now I've disabled everything besides the increment for test:
module.exports = {
bumpFiles: [
{
filename: 'app.json',
updater: require.resolve('standard-version-expo/android/increment'),
}
],
};
Gives me:
standard-version --dry-run "--release-as" "minor"
✔ bumping version in app.json from 3 to 1.1.0
✔ created CHANGELOG.md
✔ outputting changes to CHANGELOG.md
from standard-version-expo.
Maybe relevant, but I'm using these versions:
"standard-version": "^7.1.0",
"standard-version-expo": "^1.0.3"
from standard-version-expo.
Thanks for the tip, I'll add it!
from standard-version-expo.
@byCedric Hey, it's me again. 😄
Prereleases do mess up the ios buildNumber a tad:
"buildNumber": "1.1.0-0",
Is this also a config issue?
from standard-version-expo.
Related Issues (15)
- Android increments are wrong when using prereleases HOT 4
- Add support for `app.config.js` HOT 5
- Supporting `beta`? HOT 1
- Missing getenv dependency after upgrading to Expo 38.0.8
- Android converted to semver despite configs & iOS removes leading zeros in semver HOT 2
- "Manifest must include a JSON object." HOT 7
- [Discussion] How handle test versions and releases HOT 2
- Not matched value between console and execute result.
- Supporting the `expo prebuild` workflow HOT 1
- Bumping version in app.json to package.json version HOT 6
- Update @expo/config dependency to satisfy expo doctor HOT 24
- Please merge the dependabot PRs :) HOT 1
- Get sdkVersion from expo package.json HOT 3
- Add version bumpers for bare projects HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from standard-version-expo.