Giter Club home page Giter Club logo

Comments (3)

quinthar avatar quinthar commented on August 27, 2024

Tips for fixing:

  • Interesting, so this one seems like it might be due to us having unclean socket shutdown code when the incoming socket terminates before generating the response.
  • Specifically, it seems like we're calling onPortRequestComplete() on a socket that had already been closed.
  • That happens here
  • Now, we try to cancel commands queued by sockets that die. However, there is a complex edge case here where we are actively processing a command at the time the socket dies.
  • It seems like normal Bedrock handles this case fine with this line which confirms the socket exists before delivering a response
  • However, it looks like there is no corresponding check here.
  • To fix I'd suggest adding if (s) inside the if (plugin) check, with some helpful warning message like SWARN("Cannot deliver response from plugin " << plugin->getName() << "' for request '" << response["request.methodLine"] << "' #" << requestCount)`

Any volunteers?

from bedrock.

quinthar avatar quinthar commented on August 27, 2024

FYI, added an Upwork project here if anybody wants to fix this and earn a quick $500: https://www.upwork.com/jobs/~0117b61ddf80095260

from bedrock.

quinthar avatar quinthar commented on August 27, 2024

This should be fixed in HEAD; reassigning to @righdforsa until deployed.

from bedrock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.