freebsd compile assistance about bedrock HOT 15 OPEN

try GXX=clang++ CC=clang gmake

from bedrock.

Gets a little further...

% GXX=clang++ CC=clang gmake
clang++ -g -std=gnu++11 -DSVERSION="\"c178f76262d25959e73b2ecb82e5925f23045b40\"" -Wall -I/usr/home/sean/bin/Bedrock -I/usr/home/sean/bin/Bedrock/mbedtls/include -MMD -MF libstuff/libstuff.d -MT libstuff/libstuff.h.gch -c libstuff/libstuff.h
clang++: warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated
libstuff/libstuff.h:4:9: warning: #pragma once in main file [-Wpragma-once-outside-header]
#pragma once
        ^
libstuff/libstuff.h:15:10: fatal error: 'pcrecpp.h' file not found
#include <pcrecpp.h> // sudo apt-get install libpcre++-dev
         ^
1 warning and 1 error generated.
gmake: *** No rule to make target 'libstuff/libstuff.d', needed by '.build/libstuff/SData.d'.  Stop.

pcrecpp.h is here:
/usr/local/include/pcrecpp.h

from bedrock.

Hey there, we're making two changes that you might find helpful.

1. We're removing the dependency on pcre (see here: #62)

2. We've disabled the pre-compiled headers for OS X, because thus far we haven't tried to make them work with clang. See here: https://github.com/Expensify/Bedrock/blob/master/Makefile#L45

You might need to do something similar for freebsd (I'm not sure what string uname -s returns on freebsd, but you might just substitute it for "Darwin" if you have trouble here).

from bedrock.

@tylerkaraszewski,

I did see the pull request for removing pcre yesterday or so. After that's merged, I'll attempt a build again.

My uname is simply FreeBSD. After 1 is completed, I'll update the makefile and substitute with freebsd to see what happens.

Thanks!

from bedrock.

You can also just checkout that branch and see if it works for you, if you don't want to wait. :)

from bedrock.

I see you reverted the patch after it was in master for a little bit:
2cb8c40

With this being the case, can you add code to point to the pcrecpp.h?

from bedrock.

@tylerkaraszewski What's the latest plan here?

from bedrock.

We currently have no plan here. Do we want to add freebsd to a list of supported platforms?

from bedrock.

from bedrock.

I don't think we have any plans to switch back to std:regex at this point, the performance was just too poor.

from bedrock.

from bedrock.

FreeBSD has PCRE support, but if it installed as port (to /usr/local as mentioned above), clang will not find it by default (see https://wiki.freebsd.org/WarnerLosh/UsrLocal).
I think here is 2 options how to solve issue:

• make GCC the only supported compiler for FreeBSD
• modify Makefile for better support of clang on FreeBSD (or explicitly use /usr/local for -I and -L options)

from bedrock.

Well if option 1 is the default, will that still require the commit that was backed out?

from bedrock.

@jungle-boogie , I've tried to build the code on FreeBSD 11.0, but there is a couple of code issues which make build impossible, e.g.: https://github.com/Expensify/Bedrock/blob/master/libstuff/SSignal.cpp#L5 misses case of FreeBSD OS.
So, I think, there should be a set of code changes to build the project on BSD platform.

PS. Tried to compile with clang because gcc crashes on my fresh system (maybe my fault, didn't use FreeBSD since v4.4)

from bedrock.

So, I think, there should be a set of code changes to build the project on BSD platform.

Ah, good point. Once the code is added, I'm happy to test it out.

from bedrock.