Giter Club home page Giter Club logo

Comments (5)

dj8yfo avatar dj8yfo commented on June 12, 2024 1

@vldm, i assume this is covered now?

from exonum.

defuz avatar defuz commented on June 12, 2024

Why did you decide that? We use the byteorder crate and explicit conversions like LittleEndian::read_u32 and LittleEndian::write_u32 wherever the behavior between architectures may differ.

We must use a unified approach of -endianess for messages and storage data since it's protocol-specific behaviour and it is independent of the target architecture.

TLDR: The actual code should work on both architectures in the same way, but we did not test that.

Feel free to reopen issue.

from exonum.

vldm avatar vldm commented on June 12, 2024

@defuz yes, the code of u64/u16/u32 use byteorder::LittleEndian conversions, but SegmentFields slices, for example &[u64] &[u32] use transmute and Slice::from_raw which is not right way to represent architecture independent data.
@alekseysidorov reopen it pls

from exonum.

dj8yfo avatar dj8yfo commented on June 12, 2024

@defuz reopen plz.

from exonum.

defuz avatar defuz commented on June 12, 2024

@vldm You know what to do :)

from exonum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.