Giter Club home page Giter Club logo

Comments (4)

Dog avatar Dog commented on May 22, 2024

The reason for this is that a change was applied to the test to normalize case.

0314cbf
#207

It was justified because other language tracks expect normalization - specifically ruby and clojure in the pull request. I also noticed Haskell does this normalization.

from python.

behrtam avatar behrtam commented on May 22, 2024

The problem is not that normalization is tested. The problem is also not that the test is not opinionated about how to normalize case.
The problem is that the test is so minimalistic that a user wrote code that passed the test suite while the solution only works if the function gets the words in the right order.

My simple solution to the mixed case test is to expand the test string "go Go GO" to
"go Go GO Stop stop" and assume as result a dict with the values 3, 2. That would still not force the user to only normalize to lower case.

def test_mixed_case(self):
    self.assertEqual([2, 3], sorted(list(word_count('go Go GO Stop stop').values())))

from python.

kytrinyx avatar kytrinyx commented on May 22, 2024

I actually don't mind which direction the user normalizes to, and I think that it would be nice to leave that up to the person solving the problem. I like this suggested approach and wouldn't mind changing the other tracks to use it.

from python.

behrtam avatar behrtam commented on May 22, 2024

Okay, did it for the Python track.

from python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.