Comments (5)
@serialhex Thanks for wanting to contribute! @SaschaMann has the best overview of which things can actually be fixed and which things should remain errors, so I'll defer to @SaschaMann to help decide which linting errors can be fixed.
from julia.
I will probably add one that adds the authors to the authors array in config.json
. Actually writing an introduction.md
would be a bit much for me ATM, as I'm not that good of an expository writer IMHO.
from julia.
Hey @ErikSchierboom I've started working on this, and just had some comments/questions. This seems to be mostly configlet lint
type stuff, so it seems pretty easy to resolve. I'm just not sure if you want me to split it into a couple of PR's or want one big one. There are a few things of note:
- 'leap' was both a practice exercise, and a concept. I thought it keeping the concept and removing the exercise would be the way to go. Although reversing that, and removing it as a concept but leaving the practice is valid, also renaming one. IDK, input would be nice.
- There are a whole series of files missing, mostly
introduction.md
for the various concepts. It looks like these concepts are stubs with no real information in them yet. Making empty files silences configlet, so that's what I'm doing now. authors
underconfig.json
is empty in a handful of cases (mostly the stubs that I mentioned before). Adding author information for each of these is simple if I just go based on git history: You & SaschaMann (mostly). Is simply using git history sufficient or should I remove you? (as you may-or-may-not have added anything, being owner of this repo, thus your name being added to everything that gets committed) Or is there something else that you would like me to do?
Any comments are greatly appreciated!
If you like, I can split these up into 3 (or maybe more) PR's so you can check them out & add them separately. I'm fine either way.
Take care!
from julia.
Hi!
I thought it keeping the concept and removing the exercise would be the way to go.
There's an open PR for this: #365
Making empty files silences configlet, so that's what I'm doing now.
Please don't. Silencing configlet means those files will just be missed. They should either have proper content or not exist. The failure is desired behaviour.
from julia.
PRs that add content to the files that are reported missing are welcomed though, in case you want to fix the errors that way :)
from julia.
Related Issues (20)
- stage-heralding: add introduction
- vehicle-purchase: update introduction HOT 3
- some admonitions use unsupported syntax
- Exercises are listed on website despite not being in `config.json` nor `exercises/concept` HOT 4
- Concept exercise progress
- Buggy tets for Binary Search with multiple targets HOT 1
- Adding the square-root exercise HOT 1
- Link not showing properly in secret-handshake exercise
- Convert remaining mentoring notes to dig-deeper pages
- rational-numbers Ordering testset too hard
- Binary search too hard
- Rational numbers wants an approaches and better instructions
- Write dig-deeper page for darts and talk about hypot
- New practice exercise about Perceptron HOT 1
- Building a training set of tags for julia HOT 21
- Port additional exercises? HOT 2
- Progress of Verbose Unit Testing for Comprehensive Testing Summary HOT 3
- Add new exercise related to Plotting? HOT 1
- Where to add the exercise? HOT 1
- perfect-numbers: stub implementation passes all tests HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from julia.