Giter Club home page Giter Club logo

Comments (5)

ErikSchierboom avatar ErikSchierboom commented on June 27, 2024 1

@serialhex Thanks for wanting to contribute! @SaschaMann has the best overview of which things can actually be fixed and which things should remain errors, so I'll defer to @SaschaMann to help decide which linting errors can be fixed.

from julia.

serialhex avatar serialhex commented on June 27, 2024 1

I will probably add one that adds the authors to the authors array in config.json. Actually writing an introduction.md would be a bit much for me ATM, as I'm not that good of an expository writer IMHO.

from julia.

serialhex avatar serialhex commented on June 27, 2024

Hey @ErikSchierboom I've started working on this, and just had some comments/questions. This seems to be mostly configlet lint type stuff, so it seems pretty easy to resolve. I'm just not sure if you want me to split it into a couple of PR's or want one big one. There are a few things of note:

  1. 'leap' was both a practice exercise, and a concept. I thought it keeping the concept and removing the exercise would be the way to go. Although reversing that, and removing it as a concept but leaving the practice is valid, also renaming one. IDK, input would be nice.
  2. There are a whole series of files missing, mostly introduction.md for the various concepts. It looks like these concepts are stubs with no real information in them yet. Making empty files silences configlet, so that's what I'm doing now.
  3. authors under config.json is empty in a handful of cases (mostly the stubs that I mentioned before). Adding author information for each of these is simple if I just go based on git history: You & SaschaMann (mostly). Is simply using git history sufficient or should I remove you? (as you may-or-may-not have added anything, being owner of this repo, thus your name being added to everything that gets committed) Or is there something else that you would like me to do?

Any comments are greatly appreciated!

If you like, I can split these up into 3 (or maybe more) PR's so you can check them out & add them separately. I'm fine either way.

Take care!

from julia.

SaschaMann avatar SaschaMann commented on June 27, 2024

Hi!

I thought it keeping the concept and removing the exercise would be the way to go.

There's an open PR for this: #365

Making empty files silences configlet, so that's what I'm doing now.

Please don't. Silencing configlet means those files will just be missed. They should either have proper content or not exist. The failure is desired behaviour.

from julia.

SaschaMann avatar SaschaMann commented on June 27, 2024

PRs that add content to the files that are reported missing are welcomed though, in case you want to fix the errors that way :)

from julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.