Using FsUnit for more expressive tests about fsharp HOT 13 CLOSED

I'd like to see this issue stay open, so this is a contentless update so that the auto-close bot will leave the issue open.

from fsharp.

+1
I think it would be a good opportunity to give people an opportunity to see more functional F# code as they're learning. I'm not familiar at all with FsUnit, so I don't know how "complete" it is in terms of the functionality that we're using from NUnit today.

Probably the easiest way to find out would be to take some sample tests and convert them. If you add it into a project I'd be more than happy to pitch in converting some of the tests.

from fsharp.

@robkeim Great! Really appreciate it. I'll see if I can get this setup tomorrow.

from fsharp.

Oh, definitely! And there are some tests, particularly the ones where you have to re-implement a basic data structure like linked lists, that could greatly benefit from showing off something like FsCheck as well. Precisely when you'd want to teach people to use FsCheck (and Paket to install it) is a good question, but I think at some point when the tests start hitting intermediate difficulty might be best. See also my comment on #32 for more thoughts about Paket and FAKE.

from fsharp.

Good point about also introducing FsCheck, it is also ideally suited for the diamond exercise (in fact that's how I originally solved it). The only tricky thing is, as you said, determining when to introduce it.

from fsharp.

@robkeim I think I'll wait with this until I have the new setup (with FAKE and such) working, which is depending on the CLI to be updated (see this PR).

from fsharp.

Ok sounds good!

from fsharp.

Apologies @ErikSchierboom, for some reason I'm not getting notifications.

I do love FsUnit and I'm all for it to express tests better. :)

from fsharp.

I'd love to help convert tests once this is ready to begin.

from fsharp.

I'll hold you to that promise :)

from fsharp.

@ErikSchierboom I would love to contribute to this change. I am a F# newbie so I guess this will help me in learning FsUnit as well.

Now that x-api/PR124 is closed, have you started working on your setup?

from fsharp.

@tushartyagi I have not yet worked on the new setup, which will be based on .NET Core. As part of the process of converting the exercises to .NET Core, we will be creating a project file for each exercise. This will allow us to add the additional package dependency (FsUnit) automatically. Another part of the .NET Core conversion setup is to use xUnit instead of NUnit as the testing framework. As both of these frameworks are supported by FsUnit, I think it would be super convenient if we had the FsUnit tests in place, as we can then easily swap out the underlying test framework by simply replacing the opened module! 😎

All in all, I would wholeheartedly welcome you working on this issue! The help is much appreciated.

from fsharp.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from fsharp.