Create scripts to to reduce commands used to validate Pull Requests about dart HOT 8 CLOSED

I'm happy to take this one. I suggest the script(s) be written in Dart so that users can run it on any platform.

from dart.

@raphalvessa Thanks for double checking. I missed this.

from dart.

Some ideas for the script :

• By default it'll run all 5 task for all exercises.
• There should be an option to perform those tasks for a specific exercise.
• It should have option to perform specific tasks for specific exercise. (maybe not, need opinions)
• It's name should be sensible (e.g. validate-exercise) along with its args (--all, --nameOfExercise, etc)
• Possibly hook the script to git-hooks (pre-push) a non-zero exit code will abort the push.
• Should return zero exit code after successful completion, this will also be helpful in travis-ci
• more ideas here...

from dart.

Few more ideas

• If canonical-data has tests, there should exists a exercise_name_test.dart file in test directory.
• Number of tests implemented >= Number of tests in canonical-data (It's fine if there are more).
• Each test implemented has flag skip:true except the first one.
• The actual example.dart should not be imported in the exercise_name_test.dart (common mistake).
• The exercise_name.dart should be imported in exercise_name_test.dart.
• If there exists a description.md in the problem-specification, there should be a readme.md (In case the contributor didn't use our create-exercise tool. )

from dart.

There should be an option to perform those tasks for a specific exercise.

That's possible for the scripts that check dart formatting, but the configlet commands check the entire repo's configuration and contents.

It should have option to perform specific tasks for specific exercise. (maybe not, need opinions)

Currently, it would be checking the format and then formatting the exercise. Just two tasks.

Possibly hook the script to git-hooks (pre-push) a non-zero exit code will abort the push

If whoever implements it can do that and have it affect anyone that clones the repo, sure.

Number of tests implemented >= Number of tests in canonical-data (It's fine if there are more).

It would require that for every person that clones our repo and make a change, they would need to clone exercism/problem-specifications in order to run this script. I do not recommend that path.

If canonical-data has tests, there should exists a exercise_name_test.dart file in test directory.

We don't need canonical-data to have tests to know there needs to be a dart test file.

In my opinion, this suggestion and the one about validating number of tests. That can be handled during the PR.

from dart.

@raphalvessa If you can work on this, checkout the points I've written for a start. And create a PR once you're done we'll continue our discussion there for any modifications or more ideas.

from dart.

@kabiir Will do. I'll get started once I have some free time. 🙂

from dart.

I believe this issue has been addressed with PR #70, and can now be closed.

from dart.