Giter Club home page Giter Club logo

Comments (8)

kytrinyx avatar kytrinyx commented on August 12, 2024 1

This is some great troubleshooting, @Stargator. Thank you.

from dart.

iHiD avatar iHiD commented on August 12, 2024

The markdown parsing code we're using has changed for v2, so whatever turns up here will need to be applied there too.

from dart.

Stargator avatar Stargator commented on August 12, 2024

@iHiD I actually do not see the Tests page for Java in v2. Are you saying there are two different parsing logic for v2 and v1?

Since v2 of Java isn't using the TESTS.md page it's hard to tell if v2 handles v1 the same from where I am.

from dart.

kytrinyx avatar kytrinyx commented on August 12, 2024

I'm pretty sure that if we fix the markdown for v1 it will also be fixed for v2 (but yes, v2 does markdown parsing differently—better—than v1).

from dart.

Stargator avatar Stargator commented on August 12, 2024

@iHiD @kytrinyx Should this issue be closed and opened in a different repo? Since it seems to concern the markdown parsing, I want to check if this is okay.

from dart.

Stargator avatar Stargator commented on August 12, 2024

Comment from NobbZ:

Also I can confirm, that v2 suffers from the same problem, I posted the dart test-documentation straight into a comment on my own exercises ;)

from dart.

kytrinyx avatar kytrinyx commented on August 12, 2024

@Stargator Yeah, would you mind posting reproduction steps in https://github.com/exercism/v2-feedback/issues ? (A markdown comment that exhibits the same behavior as the dart test docs would probably be our best bet here)

from dart.

Stargator avatar Stargator commented on August 12, 2024

@kytrinyx I will post the same thing there as well and close this issue.

My findings:

Redcarpet with code formatting as seen in the image in the initial post does not convert to the expected html format. The code formatting breaks the numbering for lists.

I created a jekyll project to test our Markdown library redcarpet. You can find it a project for redcarpet here and a jekyll project using kramdown here.

I will be making the same post in the redcarpet project as well by COB today.

The problem remains when using quotes with redcarpet:
redcarpet-quotes

Or not using any formatting at all:
red-no-formatting

Comparatively, Kramdown does not have this issue:
kramdown-mark

Though I do not know the full scope of our use of redcarpet, so I do not know if there is anything specific that redcarpet does that we depend on.

As stated, this will be posted in the aformentioned repo by @kytrinyx as well as the redcarpet repo.

from dart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.