travis.yml: Remove presubmit from config and ensure builds fail when tests fail. about dart HOT 10 CLOSED

dartfmt has an option to do a dry run and set the exit code to 1 if there are changes. That might be a good option.

from dart.

@jvarness We ran it via the check_formatting scripting, so it runs on all platforms.

from dart.

@Stargator if your environment has the dart sdk installed though, won't it have dartfmt installed by default? Are there installations that don't include dartfmt?

from dart.

@jvarness You are right, the script allows checks the formatting of the config.json. So instead of a single line for each command we rolled similar commands together in the check_formatting.dart and the presubmit.dart scripts.

from dart.

We're not set in stone, but we wanted to run one script versus two commands to check formatting of the project and the config file. Anyone that wants this, can take it. I'm trying to wrap up a few things I had on the back burner.

from dart.

@Stargator if your environment has the dart sdk installed though, won't it have dartfmt installed by default? Are there installations that don't include dartfmt?

An additional point to make is that the SDK has a set version of the dartfmt package (dart_style). So if you want a newer version you'd have to run pub global activate dart_style. So if we add that to the script, then it would more justify manually running the dartfmt executable since it would follow updating the global package version.

from dart.

@Stargator I've been working on this but I've hit some snags.

Looks like the Dart runner for Travis doesn't honor when exit codes are set within a Dart script. I'll need to investigate a little more and get back to you.

I figured out how to make formatting fail and how to run all the tests, but there's weird stuff happening with setting exit codes.

from dart.

I've experienced this with Jenkins. I resolved it by throwing an error when the exit code was non-zero.

from dart.

Throwing the error is fine, but after rebasing with master, it looks like the jobs are now stalling when the formatting of all the files is checked:

https://travis-ci.org/jvarness/dart

from dart.

Resolved in #129

from dart.