Comments (17)
I can give this a try and see how it goes after #104 is completed, since it's dependent on that.
from bash.
Forgot about this, I'll see what I can do in the following days.
from bash.
I will look into this again after I have gotten a couple more exercises ported to the track.
from bash.
I'll have another try at this.
from bash.
That looks good and definitely something that will help, I tested it with a sample script and the suggestions were good.
One downside might be with Bats support, as per: koalaman/shellcheck#417, which is not yet merged.
from bash.
That's a great point - I didn't see this before.
If we were set on using shellcheck as a linter, we could omit testing the bats files. Equally, it seems as though there is a good PR attached to the issue, so hopefully it may be merged in the future (or just use the unmerged branch - people seem to think it works pretty well).
Conversely, I have no particular attachment to shellcheck, and as such am happy to take suggestions for any other linters 🙂
from bash.
Linting on the bats
file is the test file, and the test file gets seen by the user/learner, and therefore should be as correct as can be.
The solutions are submitted by contributors, and it would be nice to conform to conventions, but this has somewhat less exposure to a learner.
from bash.
Any progress on this one @budmc29 ? 🙂
I imagine there will be a lot of edits with this.
from bash.
Did #148 take care of this?
from bash.
No, this is a different issue.
I don't have time to work on it anymore, so if you can take over if you want.
from bash.
I'll consider this. I'm going to focus on updating the out of date tests with the generator first, so we can get version files for everything.
from bash.
I'll check later today, but I believe shellcheck gets mad if you use [ ]
instead of [[ ]]
.
I think if we implement it we will have to change all of our tests to use [[ ]]
.
from bash.
I see no issue with that, it's actually an improvement if my understand of how [[
works is correct.
from bash.
Okay, great. I will look into adding linting with shellcheck.
I guess we will need to make other scripts and bin/* follow the same guidelines.
from bash.
A glance through our example solutions suggests that most of them would need changing before they would pass linting with shellcheck. Some of them will need outright replacement
from bash.
I have closed my attempt since I don't have that much time anymore, but if anyone is interested you can see the progress I made on #234
from bash.
I'll close this. If anyone has time to pick it up, feel free to reopen.
from bash.
Related Issues (20)
- Don't need `node` for `bats`
- Pangram test fails with "bad substitution" HOT 7
- Not running tests with `bash` specifically HOT 10
- command rev is not always working in exercism tests HOT 7
- Tests for armstrong-numbers exercise do not cover numbers with leading zeros HOT 6
- The `error-handling` instructions could use more bash-specific details.
- Bash as a scripting langauge and not Yet Another Programming Language? HOT 17
- Rework headings in instructions.append.md HOT 1
- Why does this file exist in the Gigasecond exercise?
- Add check in validate_one_exercise that checks for inadvertant comment-out skips
- Copy the "Skipped tests" section from `tests.md` to `TESTS.md`
- D&D: Add a test to ensure that hitpoints is calculated from constitution
- Sync recent updates
- Is the track exercises page counting students differently? HOT 1
- Gigasecond instructions should have some bash-specific info appended
- Simplify two-fer tests _a bit_
- 'Word Count' test 'handles expanded lists' is mis-executed
- Rethink difficulty of word-count
- Building a training set of tags for bash HOT 26
- Foregone exercises HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bash.