Warning: Promise.defer is deprecated and will be removed in a future version. Use new Promise instead. about exceljs HOT 15 CLOSED

Promise.defer() is not part of the Promise API anymore:

https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Deferred

Instead of doing:

var deferred = Promise.defer();
doSomething(function cb(err, res) {
    if (err) deferred.reject(err); else deferred.resolve(res);
});
return deferred.promise;

You should do:

return new Promise(function(resolve, reject) {
    doSomething(function cb(err, res) {
        if (err) reject(err); else resolve(res);
    });
});

from exceljs.

+1

from exceljs.

+1

from exceljs.

+1

from exceljs.

+1

from exceljs.

maybe we use anothor promise lib?

from exceljs.

use Q promise?

from exceljs.

Thanks for the heads-up. Will look into it

from exceljs.

Would appreciate it...

from exceljs.

Would be great if you could fix this :)

from exceljs.

I'm currently working on adding defined names.
After that I'd like to ES6 it up - and yes, change to a new promise lib!

from exceljs.

Great!

from exceljs.

+1

from exceljs.

+1

from exceljs.

Merged and Published!

from exceljs.