Giter Club home page Giter Club logo

Comments (7)

fortenforge avatar fortenforge commented on May 21, 2024

I think items 1. 2. and 3. would be appreciated! I think stuff like adding the number of completions accepted we might want our own design team to first make a spec.

from codeium-chrome.

li-xin-yi avatar li-xin-yi commented on May 21, 2024

Thanks @fortenforge @pqn
I finished 3 on my side. Considering how to implement 2, if the popup page is immutable, I can add the option on the contextMenu like this:
image

But I'm blocked by how to disable the functionality of Codeium completion after injection (as the page is already loaded). Two approaches:

  1. Write clean-up functions for every possible editor to unregister the completion provider. It's a little complicated and time-consuming, I may need help from you.
  2. Ignore the message (completion request) from specific tabs, it sounds like a hack, I don't like it and neither do I know how to do that...

What do you think about it? Do you need me to create a draft PR with current progress and have a discussion?

By the way, I found Colab supports their built-in completion now. It might not be a good way to overwrite the Monaco completion for it.

from codeium-chrome.

pqn avatar pqn commented on May 21, 2024

Can we write the same code twice, once in each implementations (CodeMirror and Monaco), to be able to read some state change caused by the context menu? Then if Codeium is disabled behave as a noop.

By the way, I found Colab supports their built-in completion now. It might not be a good way to overwrite the Monaco completion for it.

If this is true for everyone then we can disable it.

from codeium-chrome.

li-xin-yi avatar li-xin-yi commented on May 21, 2024

If this is true for everyone then we can disable it.

Not for every user, but only some eligible ones: https://blog.google/technology/developers/google-colab-ai-coding-features/

I'm just wondering how to handle this.

from codeium-chrome.

pqn avatar pqn commented on May 21, 2024

For Colab let's leave it on for now in that case. Not sure how Monaco will choose between them but as long as the user gets some completions it's probably okay either way.

from codeium-chrome.

li-xin-yi avatar li-xin-yi commented on May 21, 2024

Hi @pqn @fortenforge, Thanks for your help.

I tried to implement 1 and 3 in this draft #51 I'm not certain whether I understand your idea correctly so I created that PR early for tests and discussion. The code is dirty now, I will clean it up further if needed. Please let me know if I misunderstand anything.

And also, should I also push the implementation of 3 in the same PR, or is it more comfortable to review and handle the code so far? Either is fine to me.

from codeium-chrome.

pqn avatar pqn commented on May 21, 2024

Thanks! I think it's fine to keep 3 in the same PR, it's not unmanageably sized right now.

from codeium-chrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.