Giter Club home page Giter Club logo

Comments (3)

alexeyzimarev avatar alexeyzimarev commented on May 26, 2024

Good point. The issue, as always, is to be able to distinguish between those services, as each shovel (will be called a Gateway in the next version) might need a different one. If you look at the current subscription builder and all the stuff related to registrations of subscriptions, you'll see how cumbersome it becomes...

Still, if we agree that the first working solution would be ok assuming only one shovel needs to be there in one application, I can enable registering a shovel without providing a function.

So, instead of:

services.AddShovel<AllStreamSubscription, AllStreamSubscriptionOptions, EventStoreProducer>("myShovel", x => {...});

You could do this:

services.AddSingleton<MyTransformer>();
services.AddSingleton<RouteAndTransform>(sp => sp.GetRequiredService<MyTransformer>.Transform);
services.AddShovel<AllStreamSubscription, AllStreamSubscriptionOptions, EventStoreProducer>("myShovel");

That can be done quickly.

from eventuous.

althunibat avatar althunibat commented on May 26, 2024

we can decide on shovel transform instance upon declaring it, this way it is not one instance which implements RouteAndTransform

services.AddSingleton<MyTransformer>();
services
    .AddShovel<AllStreamSubscription, AllStreamSubscriptionOptions, EventStoreProducer>(
        "IntegrationSubscription",
        sp=>sp.GetRequiredService<MyTransformer>.Transform
    );

from eventuous.

alexeyzimarev avatar alexeyzimarev commented on May 26, 2024

True, so, basically, for the registration a simple improvement would to accept a function to resolve the transformer.

from eventuous.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.