Comments (8)
@aslakhellesoy great job so far!
from eventsource.
Thanks! Maybe @rexxars is interested? (Found this old tweet)
from eventsource.
Hey! I'd be interested in helping/taking over, yeah. Do you have any particular goals/design principles in mind?
from eventsource.
Thanks @rexxars - much appreciated!
I want to give whomever takes it over freedom to refactor freely; Design, what language features to use, formatting etc - that's your call.
Some goals/principles off the top of my head:
Be conservative
If you allow non-standard extensions to the W3C API, only do so if it cannot be done easily with a wrapper around the library. That's why I rejected #65 for example.
Dependency free
Not sure the original
-> url-parse
dependency in there is strictly necessary!
Keep it working in browsers
Today I use the library as a browser polyfill as well as in Node. Would love to be able to do that in the future.
When I started writing this library 5 years ago my only use case was from Node.js. Then someone told me it worked as a browser polyfill after sending it through webpack. Better than other polyfills apparently. A mention at http://caniuse.com/#search=eventsource would be nice - I think they take PRs for docs.
Reject contributions without tests
If there is a bug, prove it with a failing test in one commit. Then fix it in the next commit.
Keep it open
I've been the bottleneck preventing PRs from being merged. Don't let that happen to you. I recommend setting up a GitHub organisation, and hand out commit bits liberally. Anyone who's got a PR merged gets the commit bit. I've yet to see people abuse this.
from eventsource.
Sounds pretty in line with what I was hoping for. I set up a new organization under the EventSource name and invited you as owner. Let me know if you want me to do anything specific. I'd need full repository access along with npm publishing rights.
from eventsource.
Thanks for setting up the org. I've moved it. Also created a Contributors
team (with commit bit) and added everyone in the network.
I'll add you to npm next @rexxars
from eventsource.
I've added you @rexxars with npm owner add rexxars eventsource
. I tried to set up an npm team with npm team create eventsource:owners
, but kept getting 401s, so we'll do without npm teams I guess.
Anything else you need from me?
from eventsource.
Thanks, @aslakhellesoy
I think that should be enough for now. I'll see if I can find some time to review the currently waiting PRs within the week.
from eventsource.
Related Issues (20)
- Who to contact for security issues HOT 9
- util.inherits is not a function HOT 5
- Initial connection timeout
- Error: "URL is not a constructor" HOT 2
- throwing all properties from url.parse into the request options is problematic
- connection failed silently after idle for ~10 mins
- Relative redirects do not work HOT 2
- Event() api HOT 1
- Guidance to add eventsource to vite bundler HOT 1
- [Bug] `dispatchEvent` wrong implementation
- No connection open in Electron HOT 1
- Header Last-Event-ID is not automatically sent on reconnect HOT 3
- Question about eventSourceInitDict HOT 1
- Does your eventsource library override the native node version? HOT 1
- want feature http post request HOT 10
- HTTPS traffic over a proxy is sent unencrypted
- bug: eventsource fails to reject self-signed certs if non-empty options are provided
- Property 'EventSourcePolyfill' does not exist on type 'Window & typeof globalThis'.
- why the EventSourcePolyfill could not get the sse data HOT 1
- Events dropped in streams with mixed CRLF and LF line terminators. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eventsource.