Giter Club home page Giter Club logo

Comments (3)

aslakhellesoy avatar aslakhellesoy commented on May 31, 2024

This library does indeed aim to follow the EventSource API implemented in browsers. There are many tests verifying that it does.

If you believe you've found a bug, your first step should be to prove that there is a bug with a failing test. (You skipped this step).

Your second step should be to fix the failing test.

PR #49 breaks one existing test, and you didn't add a new test.

So as it stands I think your interpretation of the spec is incorrect, but I'd be willing to reconsider if you provide a failing test and provide a link to the section of the spec we're not implementing correctly.

from eventsource.

aslakhellesoy avatar aslakhellesoy commented on May 31, 2024

@m-garg I think this is related to #45, which we rejected. Thoughts?

from eventsource.

m-garg avatar m-garg commented on May 31, 2024

Sorry for the misunderstanding. I though the EventSource.onmessage callback should be emitted regardless of the event type sent by the sse. I just tested it on Google Chrome, and the event type sent be the event-stream is being emitted, not the 'message' event. The 'message' event is only emitted only when there is no event type sent by the event-stream or the 'message' event type itself. This is exactly what this library does.
Closing the issue. Thank you for your time.

from eventsource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.