Comments (3)
This library does indeed aim to follow the EventSource
API implemented in browsers. There are many tests verifying that it does.
If you believe you've found a bug, your first step should be to prove that there is a bug with a failing test. (You skipped this step).
Your second step should be to fix the failing test.
PR #49 breaks one existing test, and you didn't add a new test.
So as it stands I think your interpretation of the spec is incorrect, but I'd be willing to reconsider if you provide a failing test and provide a link to the section of the spec we're not implementing correctly.
from eventsource.
@m-garg I think this is related to #45, which we rejected. Thoughts?
from eventsource.
Sorry for the misunderstanding. I though the EventSource.onmessage callback should be emitted regardless of the event type sent by the sse. I just tested it on Google Chrome, and the event type sent be the event-stream is being emitted, not the 'message' event. The 'message' event is only emitted only when there is no event type sent by the event-stream or the 'message' event type itself. This is exactly what this library does.
Closing the issue. Thank you for your time.
from eventsource.
Related Issues (20)
- Who to contact for security issues HOT 9
- util.inherits is not a function HOT 5
- Initial connection timeout
- Error: "URL is not a constructor" HOT 2
- throwing all properties from url.parse into the request options is problematic
- connection failed silently after idle for ~10 mins
- Relative redirects do not work HOT 2
- Event() api HOT 1
- Guidance to add eventsource to vite bundler HOT 1
- [Bug] `dispatchEvent` wrong implementation
- No connection open in Electron HOT 1
- Header Last-Event-ID is not automatically sent on reconnect HOT 3
- Question about eventSourceInitDict HOT 1
- Does your eventsource library override the native node version? HOT 1
- want feature http post request HOT 10
- HTTPS traffic over a proxy is sent unencrypted
- bug: eventsource fails to reject self-signed certs if non-empty options are provided
- Property 'EventSourcePolyfill' does not exist on type 'Window & typeof globalThis'.
- why the EventSourcePolyfill could not get the sse data HOT 1
- Events dropped in streams with mixed CRLF and LF line terminators. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eventsource.