Giter Club home page Giter Club logo

Comments (25)

JimiC avatar JimiC commented on July 29, 2024

EVEMon will not show corp jobs in the character indy monitor, unless you are a CEO or Director and provide a corp API key.
That said EVEMon, should NOT present any corp data in any character monitor, but on another corp monitor feature (which was planned to be implemented but never got done).

from evemon.

kunnis avatar kunnis commented on July 29, 2024

I've got a character that's in a corp, where I have the corp API keys, but none of those characters are directors. I think that if you enter the corp API key, it would be logical to show all of the jobs-in-progress on the various character's sheets. Or at least reflect that in the "jobs remaining" information, because the jobs remaining doesn't include that.

What are your thoughts on displaying the builds in progress for all characters where you have a corp API?

from evemon.

JimiC avatar JimiC commented on July 29, 2024

No, it's not logical to reflect the corp indy jobs in a character monitor, if those jobs weren't set by that character.

It's not as simple as you put it to reflect the "jobs remaining". Believe me I fought that "monster". There are too many parameters in play, and what you are discussing surely belongs to its own context (feature).

Btw, I'm just commenting on your issue because I was the one who implemented the indy monitoring.
I'm no longer the maintainer and I have no saying on EVEMon's future.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Agreed, I think I wasn't being clear in my earlier statement. I was thinking of only displaying the corp jobs you started in the character screen.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

This is already implemented and EVEMon also has a filtering for that (click on the "cog" icon).
This works when you provide a corp API key and any order provided from that API, match your character name.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Correct. But it doesn't work for my non-director characters, even though all the data is available to show on the non-director characters.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

Corp API key is bind to the character that issue it. That's why.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Yes, and I'd like to remove that binding.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

You shouldn't. But that's up to the current maintainer to decide.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Or make the binding share across all the characters?

from evemon.

JimiC avatar JimiC commented on July 29, 2024

Or make the binding share across all the characters?

On a corp dedicated feature? Sure. But not on the character's monitor.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

I was thinking install the director key => All characters in the director's corp get the corp jobs they started showing up up on their Active Jobs section.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

It's against EVEMon's character monitor design. If you are up to that, build a Corp Management monitor and do that there.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

It's monitoring the jobs the character installed. When you run a lot of indy jobs, you need to know which characters you need to login to service their jobs. It just so happens to be in the corp API

from evemon.

kunnis avatar kunnis commented on July 29, 2024

and to expand on this a bit more, I'd think if there was a corp management section, you'd still show the job on both the corp sheet (to get a corp overview) and the character's sheet (to get a view of what the character is doing)

from evemon.

JimiC avatar JimiC commented on July 29, 2024

OK. Let's try this again. One character issues the Corp API key (which is the CEO or Director of the Corp), so for EVEMon's character monitor only that character can see those corp indy jobs and only those that were issued by that character, because that's the point of a character monitor feature.

On a Corp Management monitor, all Corp jobs should be shown, regardless if they are already shown in the character's indy monitor.

So to answer your expanded comment, yes, some indy jobs would show in both monitors.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

I want to change and get rid of the whole issuing character requirement. I'm in the case of being a non-director that has the corp API keys.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

Again, you shouldn't change that on a character monitor level.

And on the EVE metadata gameplay front, no other character should be able to see your corp data, without permission. What if the Corp API key got stolen? Would you like your corp data to be exposed?

Your issue could be solved if CCP had given access to corp indy jobs also to the factory manager role.
We had requested that since the new API keys management was introduced, but...

from evemon.

kunnis avatar kunnis commented on July 29, 2024

That's why I'm discussing the change with you. I think we should change that. View this as the first step to building the Corp elements of the app. Decouple the Corp API key from being tied to a specific character.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

If and when EVEMon gets a Corp Management feature.

And to extend my previous comment, when you design a software you should not only assess what's possible to do, but also if you should do it. Especially when it comes to securing sensitive data.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Why not start now? I'm willing to go through and remove the ties between the Corp API key and a specific character.

I've also had this problem in the past. I had an alt-corp, with 6 alts in it. the 6 alts were doing indy work, but the corp only had one director character. I don't want to make all the alts directors just to make evemon work. However, I do understand "Don't promote people doing insecure things".

from evemon.

JimiC avatar JimiC commented on July 29, 2024

The bind should only be lifted when the Corp Management feature is implemented. And even then that feature should be bind to Corp roles.

As you can see this is no easy task.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

Why should we delay lifting the bind? Just unbind it, and on the character sheets show the corp jobs you installed, like they do for directors now.

from evemon.

JimiC avatar JimiC commented on July 29, 2024

Simple because your CEO or Director didn't gave you that permission (reminder the Corp API key was issued by the CEO - Director and only that character should be able to see the Corp data without explicit permissions).

You should better ask CCP to extend the way Corp API keys work and add role permissions to them.

from evemon.

kunnis avatar kunnis commented on July 29, 2024

The director issued the key, yes. However, it's not for info solely about the director's character. It's for info about the corp, and that's the way CCP has modeled it.

from evemon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.