Giter Club home page Giter Club logo

Comments (5)

evanshortiss avatar evanshortiss commented on May 27, 2024 5

@kenberkeley I will fix this in 6.x coming soon. Leaving the issue open until that time.

from env-var.

evanshortiss avatar evanshortiss commented on May 27, 2024 5

@kenberkeley fixed in 6.x

from env-var.

evanshortiss avatar evanshortiss commented on May 27, 2024

@kenberkeley ah so this is a README error. If you put a default value, i.e "bad-secret" in this case, then required is not available since a default value was provided. Do you want to submit a README patch like this?

// If mode is production then this is required, else use default
const SECRET = env.get('SECRET').required(NODE_ENV === 'production').asString() || 'bad-secret'

Or do you think the current behavior is problematic?

from env-var.

evanshortiss avatar evanshortiss commented on May 27, 2024

Of course, it can also be changed in the typings so you can call it since I don't think it would have any major side-effect and is probably safer.

from env-var.

kenberkeley avatar kenberkeley commented on May 27, 2024

🙏🙏🙏

from env-var.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.