Comments (4)
@nirsky this will be addressed in docs in 6.2.0
from env-var.
Internally asUrlString()
uses the url module from Node.js core (which implements WHATWG URL), and that adds the trailing slash.
Here's an example from Node.js v14.3.0.
new URL('http://a.b.com').toString()
'http://a.b.com/'
new URL('http://a.b.com/hello').toString()
'http://a.b.com/hello'
I feel like it makes sense to add the trailing slash, since in reality you're making a request to /
. Perhaps this should be noted in the README?
from env-var.
Probably worth mentioning. I spent a couple of minutes trying to understand why my request is failing.
from env-var.
@nirsky gotcha, I think a PR in docs reminding developers to use the URL module/class when working with URLs is a good idea, e.g instead of:
var path = '/thing'
var baseUrl = env.get('MY_URL').asUrlString()
// Could create invalid URL with two slashes!
var fullUrl = baseUrl + path
doing this:
var path = '/thing'
var baseUrl = env.get('MY_URL').asUrlString()
// Will be correct, with no double forward slashes
var fullUrl = new URL(path, baseUrl).toString()
Would you like to PR it?
from env-var.
Related Issues (20)
- Feature request: asRegExp() HOT 4
- Add 'example/README.md' HOT 4
- Add description() function HOT 3
- The number accessors are too permissive HOT 3
- asEnum should accept readonly T[] HOT 3
- add asMailString() HOT 4
- Configure default behavior / Support dotenv-defaults HOT 5
- Duplicate identifier causing broken build with typescript. HOT 3
- Duplicate identifier 'EnvVarError'. HOT 4
- Deno Support HOT 3
- TypeError: env.get is not a function HOT 3
- Don't default export `from(process.env)` for environments that don't have `process` HOT 6
- v8.0.0 HOT 1
- Custom validation extension/custom accessor before `as` check. HOT 2
- Client side. HOT 6
- Required() in React HOT 1
- Allow asUrlString (and maybe other checks) to be optional HOT 2
- 7.4.0 is breaking create-react-app projects that worked in prior versions HOT 11
- When testing, env variables can't be change from the test HOT 3
- Bug with `default` and `asEnum` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from env-var.