Comments (7)
Unzipping with the correct file permissions isn't implemented right now. I'll add support this weekend / early next week. Thanks for reporting the issue.
from node-unzip.
+1
from node-unzip.
I'm revisiting the design impact of permissions, as well as anything else stored in the central directory file headers at the end of the zip - see #1 and #2, after being waylaid (in a fun way) by Node Knockout. Unzip needs to decompress arbitrary zip streams, and currently does so in one incredibly fast pass in the improve-speed branch. I should be able to write each file to disk, then when the central directory headers are streamed modify files as specified.
While I'm giving this issue more thought, suggestions or pull requests (even better!) are welcome.
from node-unzip.
Hello, I made some modifications to apply permission which apparently were working fine on node-unzip 0.1.2.
I ported my fix on node-unzip 0.1.3, and now I see (not always) an error saying that the file does not exist when
I try to execute the fs.chmod.
It seems that the _readCentralDirectoryFileHeader() is called while the file is still being written to disk and not yet closed.
My feeling is that we should wait until all the files are written to disk before processing the central directory entries.
Any thoughts, ideas ?
from node-unzip.
is this still open? any update? I really need the permissions to be kept. currently manually resetting permissions. again to each file. would like to have a clean solution.
from node-unzip.
@EvanOxfeld Is this issue resolved? Or is there any flag I can pass to unzip.extract in order to preserve the file permissions?
from node-unzip.
still not fixed?
from node-unzip.
Related Issues (20)
- enhancement: Set option for deletion
- `me.error` is not a function HOT 1
- Error: invalid signature: 0x6064b50 HOT 2
- When using with typescript,the process may crash HOT 1
- Pipe signature on Entry
- Error: invalid signature: 0x70a4935 HOT 1
- Please remove dependency on 'natives HOT 5
- Does not work with nodejs v10.0.0 HOT 5
- Don't use under electron-main HOT 3
- extracted files corrupted HOT 1
- folder as file HOT 1
- DO NOT USE THIS THING HOT 8
- Not working with Node 12, primordials is not defined HOT 4
- Mode not preserved with Extract
- Update fstream to a secure version HOT 5
- Any way to pass in arguments like -j or -d from normal unzip?
- Dependency needs updating
- How to stop decompressing zip?
- primordials HOT 2
- unzipper.Parse doesn't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-unzip.