Failing Tests about device-detector-js HOT 12 CLOSED

It looks like there may be an issue with version truncation.

It's probably caused by the trailing space in the version string.

You could try to trim that space in the version util and add a test case for that.

from device-detector-js.

Could you guide me on how to add the tests as I am not comfortable with unit testing. 😞

from device-detector-js.

Sure, you just need to add a new test case in the following file: https://github.com/etienne-martin/device-detector-js/blob/0fe281df53cd9464193bd4262c257841cba36a53/src/tests/utils.test.ts after line 30.

Something like:

expect(formatVersion("14.12.2125.9740.01 ", 1)).toEqual("14.12");
expect(formatVersion(" 14.12.2125.9740.01", 1)).toEqual("14.12");
expect(formatVersion(" 14.12.2125.9740.01 ", 1)).toEqual("14.12");

from device-detector-js.

@etienne-martin, I am suspecting the issue occurs when fixtures are downloaded. Since the original library doesn't have trailing spaces in version string for yandex.

from device-detector-js.

You mean matomo-device-detector doesn't have trailing spaces in their yml files? If that's the case something's wrong with the conversion of the fixtures from yml to json.

from device-detector-js.

@etienne-martin yes matomo device detector doesn't have trailing spaces in their yml files. I will dig through the original yml files again and find the exact cases to see if they have the spaces.

from device-detector-js.

@etienne-martin I checked our converted json files to see if they have trailing spaces but it turns out that they don't. Something is going wrong somewhere. 😕

from device-detector-js.

Fixed the tests using the trim utility for now.

from device-detector-js.

Good news, feel free to open a PR with your changes

from device-detector-js.

@etienne-martin done. Take a look here: #68

Let me know if the changes are ok.

from device-detector-js.

Looks like there is a small issue I need to take care of regarding the CI.

I will publish the new version to npm once it's fixed.

Thanks for your contribution

from device-detector-js.

Sounds great.
And you are welcome. 😄

from device-detector-js.