Update of Matomo Device Detector about device-detector-js HOT 14 CLOSED

Hi @whimsicaldreamer, things changed since I posted the original instructions.

Here are the up-to-date instructions on how to update the library:

1. Pull the master branch from this repo
2. Update the https://github.com/matomo-org/device-detector#{version-number} to the latest version of matomo device detector in the package.json
3. run yarn fixtures to update to the latest fixtures. This will download the fixtures based on the version specified in the package.json
4. Run yarn test and update the library if some tests are failing
5. Open a PR

You can also skip those steps and fork this branch that is up-to-date with version 3.12.1 of matomo but with a bunch of failing tests:

It should be fairly easy to fix them. It's usually due to new devices that were added to https://github.com/matomo-org/device-detector/blob/1060530615c54796cc2045a030c7c605574060d2/Parser/Device/DeviceParserAbstract.php#L65 that needs to be added to this file.

Let me know how that goes and don't hesitate to ping me on twitter @_etiennemartin if you want a quicker response.

Thank you 🙏

from device-detector-js.

@etienne-martin I was just starting to work on it, but its great to see the new release. :) I will keep track if new releases are made and will try to PR the changes, so that this repo is up to date. Thank you for your efforts.

from device-detector-js.

Hi @arvinv,

I periodically update my fork of matomo's device-detector (https://github.com/etienne-martin/matomo-device-detector) on which this lib depends.

Here's what I need to do in order to make my lib up-to-date with matomo's lib:

1. Update the https://github.com/matomo-org/device-detector#{version-number} to the latest version of matomo device detector in the package.json
2. run yarn fixtures to update to the latest fixtures
3. Run yarn test and update the library if some tests are failing
4. Open a PR

Maybe I forgot something, last time I updated it was Sep 17, 2018. I should definitely write some documentation about the process.

Thanks.

from device-detector-js.

Thanks for the information.

from device-detector-js.

@arvinv I just ugraded the lib to 3.11.2

from device-detector-js.

Hi @etienne-martin matomo device detector has upgraded to 3.11.7. Will you be updating it soon?

from device-detector-js.

Ideally yes, but I'm pretty swamped right now. Feel free to follow these steps and open a PR.

from device-detector-js.

I am not sure but the fork https://github.com/etienne-martin/matomo-device-detector gives 404 to me.

from device-detector-js.

@etienne-martin @AlexBeauchemin I was hoping if you could guide me on the way to update this library. I have forked the original matomo device detector library and also this library. Then I created a branch from master of the original library and then updated the napa field with the branched URL. Ran npm install and also npm run test. All tests seemed to pass but how do I understand if this library is really updated?

from device-detector-js.

Well, no need to do anything, I just released v2 which is up-to-date with matomo. Thanks for offering help tho

from device-detector-js.

Btw, in the readme, https://github.com/etienne-martin/device-detector-js#why-are-the-tests-failing-after-downloading-new-fixtures, "this file" link is dead. And also https://github.com/etienne-martin/device-detector-js#this-is-a-javascript-port-of-matomo-device-detector-3114, the version number needs to be updated to the recent one.

from device-detector-js.

Thanks a lot, I did fix the version number but didn't notice the broken link, good catch!

from device-detector-js.

Should be fixed now, let me know if you find anything else and thanks again

from device-detector-js.

Great! Will let you know in case if I find something more, or else I will do a PR.

from device-detector-js.