Giter Club home page Giter Club logo

Comments (5)

Subway2023 avatar Subway2023 commented on September 21, 2024
contract SomeOtherContract {
    function f() public returns (int){
        return 2;
    }
}
contract ExampleContract {
    SomeOtherContract public otherContract;
    function f() public{
        otherContract = new SomeOtherContract();
        assert(otherContract.f()==2);
    }
}

If the called function is located in another contract, the SMTChecker correctly determines the return value.

from solidity.

blishko avatar blishko commented on September 21, 2024

The difference is not in whether or not the function is in the same or other contract, the difference is that in the second example, the function returns a constant value, while in the first one it returns x+1. BMC engine does not keep context around so it does not know that x never changes. CHC engine is more powerful and should work as expected on this example. @Subway2023, can you confirm this?

from solidity.

Subway2023 avatar Subway2023 commented on September 21, 2024
contract SomeOtherContract {
    function f() public returns (int){
        return 2;
    }
}
contract ExampleContract {
    SomeOtherContract public otherContract;
    function f() public{
        otherContract = new SomeOtherContract();
        assert(otherContract.f()==2);
    }
}

If the called function is located in another contract, the SMTChecker correctly determines the return value.

solc SomeOtherContract.sol --model-checker-engine all

1713346077892

from solidity.

blishko avatar blishko commented on September 21, 2024

This is because it is an external call, which in general cannot be trusted even though it is a contract in the same source.
If you want to trust external call to known contracts you can add the option --model-checker-ext-calls trusted.
With this option CHC engine verifies that the assertion cannot be violated.

from solidity.

blishko avatar blishko commented on September 21, 2024

The current behaviour matches the expected behaviour, so I am closing this issue.

from solidity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.