Comments (6)
Maybe we should also include the #14839 (comment) package.
Yeah, if it's not already there. Our Python tests require it and they work so I assume it's there.
Choose the default Python version in the base image
An important part of that is to then switch from python3
to python
where needed and remove the hard-coded Python version (3.12) from the Windows Python job.
from solidity.
Yeah, if it's not already there. Our Python tests require it and they work so I assume it's there.
They are not, most of the python packages are installed per-job/step basis. For example: https://github.com/ethereum/solidity/blob/develop/.circleci/config.yml#L914 and https://github.com/ethereum/solidity/blob/develop/.circleci/config.yml#L1441
from solidity.
Interesting. t_ubu_pyscripts
does not install it even though unit tests require it (at least they did when I ran them locally in a clean virtualenv). It's actually weird because it randomly failed in my PR a few times due to missing requests
but it went away after some reruns.
By the way, we should add those packages listed for chk_pylint
to the base image too. The less we have to install at runtime in CI, the better, unless something has to be really bleeding edge like Foundry.
from solidity.
Add parsec and tabulate python packages to base image, as noted here. Maybe we should also include the #14839 (comment) package.
Should we not just have a requirements.txt
file and install the same dependencies everywhere. At the moment, requests
is not present in the Windows images, but is in all of the other ones.
from solidity.
Maybe. The issue is that we require quite a few packages, some of which could be quite heavy or exotic but each script individually needs only one or two of them.
Another complication is that I can easily see us adding something to the requirements.txt
but forgetting to update the images so maybe the image would be better place to list them.
But overall I'm not against the idea if we can solve these problems. Having a common base that we can rely on being always present would also be pretty convenient. I'm usually reluctant to add dependencies when writing one-off Python scripts because ensuring that I have them everywhere I need it is cumbersome.
from solidity.
Maybe. The issue is that we require quite a few packages, some of which could be quite heavy or exotic but each script individually needs only one or two of them.
Another complication is that I can easily see us adding something to the
requirements.txt
but forgetting to update the images so maybe the image would be better place to list them.But overall I'm not against the idea if we can solve these problems. Having a common base that we can rely on being always present would also be pretty convenient. I'm usually reluctant to add dependencies when writing one-off Python scripts because ensuring that I have them everywhere I need it is cumbersome.
By the way, your PR that was failing previously (3.11) is now passing (3.12). I've opened a draft PR #14873 to force install python 3.12 via chocolatey, and provide a symlink from that. Not exactly the prettiest approach, but should provide a stable fix for the time being.
from solidity.
Related Issues (20)
- Member not unique after argument-dependent lookup, really ?
- Identified potential issues in the current implementation of the Solidity command-line compiler. HOT 1
- Add `abi.decodeCall` reciprocal function of `abi.encodeCall`
- Declaring struct at null memory location
- Function selectors from inherited interfaces are not visible in parent interface HOT 1
- [SMTChecker] Bug: Inconsistent Storage Array Bytes Writing HOT 4
- Support for Inlining HOT 2
- assignment to struct in array HOT 1
- Redundant DUP1 and POP in CallValueCheck
- Parser fails when decoding with abi.encode, thus it doesn't allow unpacking to variables that are declared differently (e.g. statement-declared and the ones declared in advance) HOT 5
- Optimized PUSH0 and POP in clearStorageLoop HOT 2
- Optimize resizeDynamicArray
- Segmentation fault in solc in function solidity::frontend::experimental::Analysis::annotationContainer, file libsolidity/experimental/analysis/Analysis.cpp HOT 6
- Deduplicate bytecode dependencies used by both creation and deployed object HOT 2
- Reuse optimized IR/bytecode for bytecode dependencies
- SMTChecker: Underflow and overflow targets not checked or reported on the same expression for BMC engine HOT 1
- Redundant `ISZERO` and `PUSH20 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF AND` in covertType
- [Yul EVM code transform] Stack too deep in standalone Yul test case
- ICE in `Z3Interface::fromZ3Expr()` when running tests on Arch Linux HOT 8
- Seems like an incorrect type inference... HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solidity.