add example for an already fixed bug in the feature file, to sure it won't happen again. about pyethereum HOT 6 CLOSED

can't reproduce the bug even without your modified code,
my test example maybe not be the exact case you reported.
So I delegate this issue to @vbuterin
Please modify features/trie.feature on line: 144 to reflect it.

from pyethereum.

maybe 44264f5 already fixed the bug,
but anyway, I want the example to be presented in the feature file.

from pyethereum.

That is weird. The bug is showing very clearly for me:

u = trie.Trie('/tmp/random_sub_directory')
u.root = ''
u.update('\x03\xe8','1')
[' \x03\xe8', '1']
u.update('\x03\xe9','2')
['\x10>', ['', '', '', '', '', '', '', '', [' ', '1'], [' ', '2'], '',
'', '', '', '', '', '']]
u.update('\x01\xf4','')
['\x10', 'D\xb2\x9fo\x17\x13<\xac\x02v\xb6\x90ke\x813\x99\x88v
\x8e\x0e\xf8\xdfk\xdd\xe3\xf3\x04\xf0\xe4\xca']

from pyethereum.

>> u.update('\x01\xf4','')

This will store a empty string to key \x01\xf4,
the current trie tree can accept and store any thing that can be rlp encoded, so emtpy string, list are all valid.

If you run

>> u.delete('\x01\xf4')

The result will be different, which internally has a empty string together with a value_is_node=True parameter invoked with _update.

from pyethereum.

Okay, thanks. Didn't realize you separated out update-to-empty and
delete. I think that solves the problem.

On 14-04-10 05:55 AM, chenhouwu wrote:

u.update('\x01\xf4','')

This will store a empty string to '\x01\xf4',
the current trie tree can accept and store any thing that can be rlp
encoded, so emtpy string, array are all valid.

If you run

u.delete('\x01\xf4')

The result will be different, which internally has a |empty string|
together with a |value_is_node=True| parameter invoked with _update.

—
Reply to this email directly or view it on GitHub
#57 (comment).

from pyethereum.

@vbuterin in commit: 563bcc7

1. fixed the to_dict bug,
2. also modified the test code, so now trie test has 1/3 probability to have empty string as value.
   3 remove the extra normalization code

all test passed.

from pyethereum.