Giter Club home page Giter Club logo

Comments (5)

holiman avatar holiman commented on May 9, 2024 4

Thanks for investigating @eggy-eth I have closed them both as false positives, but I hope you continue to try to find flaws in the implementations!

from pm.

DarkDaoCharlieBrown avatar DarkDaoCharlieBrown commented on May 9, 2024 2

Please allow time for flirting, weed smoking and price talk.

from pm.

eggy-eth avatar eggy-eth commented on May 9, 2024 1

I'd like to point out that when I tested geth it does not look like it is EIP-1014 compliant. I wonder if it has been tested, since it seems like the tests are there?

CREATE2 can re-run constructor multiple times in a selfdestructed contract

CREATE2 can be ran twice creating code at the same address instead of reverting

EDIT: This hence might be a reason for another delay in the HF since my gut says that there will be consensus issues between parity/geth if it is not implemented according to EIP 1014 in geth so far.

EDIT: I have understood EIP 1014 wrong and hence thought these were issues while they are not.

from pm.

holgerd77 avatar holgerd77 commented on May 9, 2024

Can't join the call, so here an update from EthereumJS on Constantinople:

We are making good progress and now have substantial parts of all EIPs implemented - latest merging the SSTORE implementation. So I am somewhat confident that we can do a Constantinople-ready release of the VM within the next 1-2 weeks.

from pm.

lrettig avatar lrettig commented on May 9, 2024

Closing in favor of #60

from pm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.