Add library prefix to all ckzg symbols about c-kzg-4844 HOT 7 CLOSED

Hello, that seems like a promising approach to solving the problem, and requires less tinkering of the audited code than making FIELD_ELEMENTS_PER_BLOB configurable. I can look next week at how to achieve this (since honestly I have no idea). Thanks for the suggestion.

from c-kzg-4844.

So, I pushed #313 which includes some cursed macro code 2c58b2a that gets used around the codebase 6253751 .

To use this cursed feature you need to define a LIB_PREFIX as follows: LIB_PREFIX=ckzg

Would this work for you guys?

Either way, I think we should probably wait until Justin is back from OOO to see if this is acceptable in terms of code quality. I don't really like it, but if it's a needed feature I can probably turn a blind eye.

from c-kzg-4844.

digging this approach 🎉

from c-kzg-4844.

@asn-d6 That looks like it would work for us, and I don't think the macros are too bad from an aesthetics/maintainability PoV. If I get some time I'll try to re-work the Rust bindings and confirm that it works end-to-end.

Thanks for your work on that!

from c-kzg-4844.

Either way, I think we should probably wait until Justin is back from OOO to see if this is acceptable in terms of code quality. I don't really like it, but if it's a needed feature I can probably turn a blind eye.

Yeah, let's wait for his comment, but I think the PR already looks good.

from c-kzg-4844.

Either way, I think we should probably wait until Justin is back from OOO to see if this is acceptable in terms of code quality. I don't really like it, but if it's a needed feature I can probably turn a blind eye.

Yeah, let's wait for his comment, but I think the PR already looks good.

Reviewed the PR yesterday. I'm not ecstatic about it either, but I think it's a clever solution with minimal changes. I want to look into how complicated it would be to do it "properly". Maybe we do it this way now & the complicated way later.

from c-kzg-4844.

Fixed in #317. Closing.

from c-kzg-4844.