Comments (6)
Ok, the issue is that "this.base.options.port" is empty:
node_modules/socket.io/support/socket.io-client/socket.io.js:819: + ':' + this.base.options.port
When setting the port to 443 manually it works using Firefox and Opera*.
- Unfortunately Opera only shows the Pad, GUI, Colors, etc. but doesn't seem to send status updates (no error found in any log)
from etherpad-lite.
And here is a quickfix:
--- orig/node_modules/socket.io/support/socket.io-client/socket.io.js 2011-05-23 22:38:54.000000000 +0200 +++ patched/node_modules/socket.io/support/socket.io-client/socket.io.js 2011-05-25 13:55:32.000000000 +0200 @@ -814,6 +814,9 @@ if (typeof window != 'undefined'){ * @api private */ WS.prototype.prepareUrl = function(){ + /* Quick workaround for issue 14: */ + if ('' == this.base.options.port) + this.base.options.port = this.base.options.secure ? '443' : '80' return (this.base.options.secure ? 'wss' : 'ws') + '://' + this.base.host + ':' + this.base.options.port
from etherpad-lite.
You should submit that to the socket.io repository.
from etherpad-lite.
You might be right, although the "fix" is very ugly and doesn't solve the root cause. Anyway: socketio/socket.io#161 (hope this is the correct repository).
from etherpad-lite.
It might not like the way I'm initalizing socket.io https://github.com/Pita/etherpad-lite/blob/master/static/js/pad2.js#L63 - I will experiment tomorrow with that.
from etherpad-lite.
I think I solved that with this commit Pita/etherpad-lite@18ec4da
from etherpad-lite.
Related Issues (20)
- How to change the admin password with Etherpad Lite that runs inside a docker container? HOT 2
- v2.0.0: installing plugins from registry in docker fails HOT 5
- Unable to access admin page "Error: ENOENT: no such file or directory, stat '/home/lufi/etherpad-lite/src/templates/admin/index.html' HOT 1
- docker build fails with pnpm-lock.yaml missing HOT 2
- Plugins' subdepencies are not being installed HOT 1
- installing etherpad plugins from GitHub repos is broken
- No Basic Auth HOT 2
- Pinning support when installing plugins HOT 2
- Unknown file extension ".ts" for server.ts HOT 9
- How to remove plugins ? HOT 4
- Support proxy server in plugin installation script HOT 11
- No admin templates - Etherpad 2.0.1 HOT 7
- Etherpad-lite 2.0.1: start.bat problem in windows HOT 4
- Etherpad 2.0.1: Depreciation error and git version warning HOT 4
- How to delete a pad when you can't use the admin interface HOT 1
- Update from 1.9.7. to 2.0.1 fails [Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/pnpm'] HOT 1
- systemd service file for v2.0 (was: unexpected string in JSON after upgrade to v2) HOT 30
- Fail to run Docker image: `No projects matched the filters in "/opt/etherpad-lite"` HOT 2
- the BUG of font_family v0.5.44 HOT 1
- Add a special ChatGPT user HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from etherpad-lite.