Giter Club home page Giter Club logo

Comments (6)

AlexanderWillner avatar AlexanderWillner commented on May 15, 2024

Ok, the issue is that "this.base.options.port" is empty:

node_modules/socket.io/support/socket.io-client/socket.io.js:819:    + ':' + this.base.options.port

When setting the port to 443 manually it works using Firefox and Opera*.

  • Unfortunately Opera only shows the Pad, GUI, Colors, etc. but doesn't seem to send status updates (no error found in any log)

from etherpad-lite.

AlexanderWillner avatar AlexanderWillner commented on May 15, 2024

And here is a quickfix:

--- orig/node_modules/socket.io/support/socket.io-client/socket.io.js   2011-05-23 22:38:54.000000000 +0200
+++ patched/node_modules/socket.io/support/socket.io-client/socket.io.js    2011-05-25 13:55:32.000000000 +0200
@@ -814,6 +814,9 @@ if (typeof window != 'undefined'){
    * @api private
    */
   WS.prototype.prepareUrl = function(){
+    /* Quick workaround for issue 14: */
+    if ('' == this.base.options.port)
+       this.base.options.port = this.base.options.secure ? '443' : '80'
     return (this.base.options.secure ? 'wss' : 'ws') 
     + '://' + this.base.host 
     + ':' + this.base.options.port

from etherpad-lite.

hanspinckaers avatar hanspinckaers commented on May 15, 2024

You should submit that to the socket.io repository.

from etherpad-lite.

AlexanderWillner avatar AlexanderWillner commented on May 15, 2024

You might be right, although the "fix" is very ugly and doesn't solve the root cause. Anyway: socketio/socket.io#161 (hope this is the correct repository).

from etherpad-lite.

Pita avatar Pita commented on May 15, 2024

It might not like the way I'm initalizing socket.io https://github.com/Pita/etherpad-lite/blob/master/static/js/pad2.js#L63 - I will experiment tomorrow with that.

from etherpad-lite.

Pita avatar Pita commented on May 15, 2024

I think I solved that with this commit Pita/etherpad-lite@18ec4da

from etherpad-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.